Review main Merged

67315[DOCS] Add hint how to alter or remove hreflang tags

Richard Haeser CR +2 V +2 Easy +7 −4 updated 01/01/21, 19:26

Commit message

In some edge cases you may want to disable or change the rendering of
the hreflang tags. We added some hints how to deal with such cases.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Martin Kutschker +1
    • Christian Kuhn +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Martin Kutschker +1
    • Christian Kuhn +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Richard Haeser uploaded patch set 1 12/30/20, 10:22

  2. TYPO3com voted on patch set 1 V +1 12/30/20, 10:32 Completed build in 09m 49s on Wed, 30 Dec, 10:32 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8503

  3. Martin Kutschker voted on patch set 1 V +1 CR +1 12/30/20, 10:40

  4. Benjamin Franzke commented on patch set 1 12/30/20, 10:52

    Index.rst:120 Unresolved

    "should be listening" or better "should listen"

    Index.rst:122 Unresolved

    My initial thought was: "well, ok, and how would I one do that". Therefore maybe better say "ordered", so it's clear that event listener ordering is to be used?
  5. Richard Haeser uploaded patch set 2 12/31/20, 07:12

  6. Richard Haeser uploaded patch set 3 12/31/20, 07:13

  7. TYPO3com commented on patch set 2 12/31/20, 07:23 Completed build in 10m 19s on Thu, 31 Dec, 07:23 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8513

  8. TYPO3com voted on patch set 3 V +1 12/31/20, 07:26 Completed build in 13m 00s on Thu, 31 Dec, 07:26 AM Test Summary: 32539 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8514

  9. Tymoteusz Motylewski voted on patch set 3 V +1 CR +1 12/31/20, 10:57

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 01/01/21, 17:02

  11. Martin Kutschker voted on patch set 3 V +1 CR +1 01/01/21, 19:25

  12. Richard Haeser voted on patch set 3 V +2 CR +2 01/01/21, 19:26

  13. Richard Haeser merged patch set 4 01/01/21, 19:26