Review main Merged

67316[BUGFIX] Assure page title editing when creating new pages

Elias Häußler CR +2 V +2 Hard +262 −2 updated 01/16/21, 13:18

Commit message

Using drag and drop, one can create new pages within the
page tree. New pages can be created before, after or
within existing pages. Currently, one could not provide
a page title if the page was created within a page
without subpages due to issues with unintended focus
change after drag and drop.

It is now ensured that a page title can be edited
directly after dragging a page into the page tree. Some
cases are also covered by acceptance tests now.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1016

  1. Elias Häußler uploaded patch set 1 12/30/20, 18:27

  2. TYPO3com voted on patch set 1 V -1 12/30/20, 18:37 Completed build in 09m 55s on Wed, 30 Dec, 06:37 PM Test Summary: 2 of 32785 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8510

  3. Elias Häußler uploaded patch set 2 12/30/20, 18:44

  4. TYPO3com voted on patch set 2 V +1 12/30/20, 18:53 Completed build in 08m 45s on Wed, 30 Dec, 06:53 PM Test Summary: 32544 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8511

  5. Elias Häußler wrote 12/30/20, 18:56

    Topic set to pagetree
  6. Richard Haeser voted on patch set 2 V +1 CR +1 12/31/20, 07:25

  7. Richard Haeser uploaded patch set 3 01/03/21, 19:02

  8. TYPO3com voted on patch set 3 V -1 01/03/21, 19:14 Completed build in 11m 16s on Sun, 3 Jan, 07:13 PM Test Summary: 1 of 32791 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8561

  9. TYPO3com commented on patch set 3 01/03/21, 19:22 Completed build in 12m 01s on Sun, 3 Jan, 07:22 PM Test Summary: 1 of 29719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8562

  10. TYPO3com commented on patch set 3 01/03/21, 19:26 Completed build in 11m 43s on Sun, 3 Jan, 07:26 PM Test Summary: 8 of 32791 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8563

  11. TYPO3com voted on patch set 3 V +1 01/03/21, 20:46 Completed build in 09m 04s on Sun, 3 Jan, 08:46 PM Test Summary: 32550 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8566

  12. Richard Haeser voted on patch set 3 V +1 CR +1 01/03/21, 20:46

  13. Oliver Hader voted on patch set 3 CR +1 01/14/21, 08:57

  14. Guido Schmechel commented on patch set 3 V +1 01/16/21, 13:02

    Good catch!
  15. Richard Haeser voted on patch set 3 V +2 CR +2 01/16/21, 13:18

  16. Richard Haeser merged patch set 4 01/16/21, 13:18