Review main Merged

67317[BUGFIX] FormEngine: Fix several validation issues in complex field types

Andreas Kienast CR +2 V +2 Easy +23 −18 updated 01/06/21, 22:36

Commit message

The FormEngine field type `selectMutlipleSideBySide` is very special, as
it's a combination of four input and select fields. With the refactoring
done in #87324 an issue in the validation has been introduced which
caused the validation of the wrong field which contains no validation
rules. This patch uses the correct field to obtain the validation rules
from, now.

Another issue is that values of `selectCheckBox` never have been
validated as the necessary validation rules were missing. The rules are
now appended to the outermost div container. In the same run, minor
styling and markup changes were necessary.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 7

Review log 1221

  1. Andreas Kienast uploaded patch set 1 12/31/20, 08:44

  2. Andreas Kienast commented on patch set 1 V -1 12/31/20, 08:49

    Adding a new value to fulfill "minitems" results in a validation error. On it.
  3. TYPO3com voted on patch set 1 V +1 12/31/20, 08:53 Completed build in 09m 42s on Thu, 31 Dec, 08:53 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8515

  4. Andreas Kienast uploaded patch set 2 12/31/20, 09:32

  5. TYPO3com voted on patch set 2 V -1 12/31/20, 09:42 Completed build in 09m 53s on Thu, 31 Dec, 09:42 AM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8516

  6. TYPO3com commented on patch set 2 12/31/20, 10:10 Completed build in 46m 01s on Thu, 31 Dec, 10:09 AM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8516

  7. TYPO3com voted on patch set 2 V +1 12/31/20, 10:16 Completed build in 1h 29m 41s on Thu, 31 Dec, 10:16 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8516

  8. Richard Haeser voted on patch set 2 V +1 CR +1 12/31/20, 10:18

  9. Andreas Kienast uploaded patch set 3 01/05/21, 15:30

  10. Richard Haeser voted on patch set 3 V +1 CR +1 01/05/21, 15:43

  11. TYPO3com voted on patch set 3 V -1 01/05/21, 15:45 Completed build in 15m 02s on Tue, 5 Jan, 03:45 PM Test Summary: 31758 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8628

  12. TYPO3com voted on patch set 3 V +1 01/05/21, 15:57 Completed build in 41m 56s on Tue, 5 Jan, 03:57 PM Test Summary: 32545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8628

  13. Andreas Kienast uploaded patch set 4 01/06/21, 11:15

  14. TYPO3com voted on patch set 4 V -1 01/06/21, 11:28 Completed build in 12m 12s on Wed, 6 Jan, 11:28 AM Test Summary: 1 of 32798 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8676

  15. Oliver Klee updated the commit message in patch set 5 01/06/21, 11:39

  16. TYPO3com voted on patch set 4 V +1 01/06/21, 11:46 Completed build in 42m 55s on Wed, 6 Jan, 11:46 AM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8676

  17. TYPO3com voted on patch set 5 V +1 01/06/21, 11:51 Completed build in 10m 22s on Wed, 6 Jan, 11:51 AM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8680

  18. Christian Kuhn voted on patch set 5 V +1 01/06/21, 12:27

  19. Oli Bartsch voted on patch set 5 V +1 CR +1 01/06/21, 13:20

  20. Richard Haeser voted on patch set 5 V +2 CR +2 01/06/21, 22:36

  21. Richard Haeser merged patch set 6 01/06/21, 22:36