Review main Merged

67320[FEATURE] Resolve collection types of non-persistent objects

Nikita Hovratov CR +2 V +2 Normal +89 −3 updated 09/02/21, 18:04

Commit message

Collection types of persistent domain objects are already resolved.
This patch adds this feature to the normal ObjectConverter. This is
especially useful when making use of DTOs.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1622

  1. Nikita Hovratov uploaded patch set 1 12/31/20, 21:10

  2. TYPO3com voted on patch set 1 V +1 12/31/20, 21:19 Completed build in 09m 23s on Thu, 31 Dec, 09:19 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8529

  3. Benni Mack commented on patch set 1 03/22/21, 19:00

    Hey, thanks for your patch. Can you provide a Feature RST and some more insights of the benefits of using symfony/property-info?
  4. Nikita Hovratov uploaded patch set 2 06/22/21, 15:45

  5. core-ci voted on patch set 2 V -1 06/22/21, 15:48 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12673

  6. Nikita Hovratov commented on patch set 2 06/22/21, 15:53

    Reply

    This is useful when property mapping an incoming extbase form request to a model with some sort of ObjectStorage property. For example this does work now: /** * @param ObjectStorage<IntRange> $ranges */ public function setRanges(ObjectStorage $ranges): void { $this->ranges = $ranges; }
  7. Nikita Hovratov uploaded patch set 3 06/22/21, 16:01

  8. core-ci voted on patch set 3 V +1 06/22/21, 16:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12674

  9. Nikita Hovratov commented on patch set 3 06/22/21, 16:13

    Reply

    BTW since doc block parameters are deprecated now, would this trigger an error? There is no alternative for defining such collections right now, is there?
  10. Benni Mack wrote 07/05/21, 19:51

    Removed reviewer Benni Mack.
  11. Benni Mack commented on patch set 3 07/05/21, 19:52

    Reply

    Good question
  12. Nikita Hovratov uploaded patch set 4 09/01/21, 15:48

  13. core-ci voted on patch set 4 V -1 09/01/21, 16:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16016

  14. Nikita Hovratov uploaded patch set 5 09/01/21, 16:39

  15. core-ci voted on patch set 5 V -1 09/01/21, 16:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16018

  16. Nikita Hovratov uploaded patch set 6 09/01/21, 16:57

  17. Nikita Hovratov commented on patch set 5 09/01/21, 17:00

    Reply

    Ok, it won't log deprecation errors. It does only do so for the main type. This means we need a replacement for this annotation, so dropping the docblock parser will be possible. Maybe with PHP 8 attributes?
  18. core-ci voted on patch set 6 V +1 09/01/21, 17:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16019

  19. Nikita Hovratov commented on patch set 6 09/01/21, 17:17

    If you need a quick way to verify, try with this extension: https://github.com/nhovratov/typo3-collection-testextension Create some "leaves" and add the plugin "Test" to any page. Then open the page and select some checkboxes and submit. If it works, you will see a debug output.
  20. Benni Mack voted on patch set 6 V +1 CR +1 09/02/21, 11:52

  21. Christian Kuhn voted on patch set 6 V +2 CR +2 09/02/21, 18:03

  22. Christian Kuhn merged patch set 7 09/02/21, 18:04