Review main Abandoned

67321[WIP][TASK] Remove empty TypeScript interface assets

Benjamin Franzke CR 0 V 0 Normal +22 −148 updated 08/31/21, 08:36

Commit message

The TYPO3 TypeScript sources use the convention that
files containing interfaces (only) end in Interface(s).ts.
That means these files do not need to be provided as
separate AMD modules, as these modules are actually empty.

These files are now ignored during build and therefore their
generated assets are removed.

Those TypeScript modules that missed the Interface suffix
are renamed to adhere to the same convention and are
therefore ignored during build as well.

TODO:
 * Fix eslint to not run out of memory because
   of the excluded files

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 17

Review log 45

  1. Benjamin Franzke uploaded patch set 1 01/01/21, 14:27

  2. TYPO3com voted on patch set 1 V -1 01/01/21, 14:38 Completed build in 11m 08s on Fri, 1 Jan, 02:38 PM Test Summary: 1 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8532

  3. Benni Mack commented on patch set 1 04/29/21, 17:20

    What's with this one?
  4. Benjamin Franzke abandoned the change 08/31/21, 08:36

    I experienced problems in follow patched with excluding those files via tsconfig.json. Seems there is no proper solution when using `tsc` directly. Could rather be fixed when migrating to rollup or webpack at some point. and BTW: Other projects (like lit) do the same and ship those empty files.
  5. Benjamin Franzke commented on patch set 1 08/31/21, 08:36

    Reply

    I experienced problems in follow patched with excluding those files via tsconfig.json. Seems there is no proper solution when using `tsc` directly. Could rather be fixed when migrating to rollup or webpack at some point. and BTW: Other projects (like lit) do the same and ship those empty files.