67323[TASK] Replace missing jquery import in SelectTreeElement
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1518
-
Benjamin Franzke uploaded patch set 1 01/01/21, 14:58
-
Benjamin Franzke updated the commit message in patch set 2 01/01/21, 14:59
-
TYPO3com voted on patch set 1 V +1 01/01/21, 15:08 Completed build in 09m 40s on Fri, 1 Jan, 03:08 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8534
-
TYPO3com voted on patch set 2 V +1 01/01/21, 15:10 Completed build in 10m 49s on Fri, 1 Jan, 03:10 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8535
-
Tymoteusz Motylewski commented on patch set 2 CR +1 01/04/21, 23:04
ie is not supported in v11, so were good to go -
Richard Haeser voted on patch set 2 V +1 CR +1 01/07/21, 03:03
-
Christian Kuhn voted on patch set 2 V +2 CR +2 01/07/21, 11:31
-
Christian Kuhn voted on patch set 2 V 0 CR 0 01/07/21, 11:34
-
Christian Kuhn commented on patch set 2 V -1 01/07/21, 11:50
Patch leads to 500 in ajax calls when opening ext:styleguide 'elements select' record (the table with the select tree examples) -
Richard Haeser commented on patch set 2 V 0 01/07/21, 12:03
Reply
I thought I had these errors as well without this patch, but not completely sure anymore. -
Richard Haeser commented on patch set 2 CR 0 01/07/21, 12:05
Reply
You are right. Error doesn't show up in master -
Benjamin Franzke commented on patch set 2 CR -1 01/07/21, 12:07
Reply
Thank you very much, you are right, it isn't working correctly there. I tried to identify cases where nested arguments are encoded, but I didn't found this case. 😞 Background: URLSearchParams only works on linear arrays, while $.param encodes recursively). dataStructureIdentifier is not a string. Will look into it. -
Benjamin Franzke uploaded patch set 3 01/07/21, 12:37
-
TYPO3com voted on patch set 3 V +1 01/07/21, 12:47 Completed build in 10m 13s on Thu, 7 Jan, 12:47 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8729
-
Christian Kuhn voted on patch set 3 V +1 CR +1 01/07/21, 13:09
-
Oli Bartsch voted on patch set 3 V +1 CR +1 01/07/21, 13:20
-
Benjamin Franzke voted on patch set 3 V +2 CR +2 01/07/21, 13:37
-
Benjamin Franzke merged patch set 4 01/07/21, 13:37