Review main Merged

67324[TASK] Update various dependencies to support PHP8

Benni Mack CR +2 V +2 Hard +466 −353 updated 01/01/21, 17:01

Commit message

A few dependencies now have PHP8 support and PHP 7.2 support,
which we then update to the latest versions, also for v10.4.

Updated dev-dependencies:
* composer req "phpspec/prophecy:^1.12.2" --dev --with-all-dependencies
* composer req "friendsofphp/php-cs-fixer:^2.17.3" --dev --with-all-dependencies
* composer req "phpstan/phpstan:^0.12.64" --dev --with-all-dependencies
* composer req "phpunit/phpunit:^8.5.13" --dev --with-all-dependencies

Non-dev-dependency updates:
* composer req "nikic/php-parser:^4.10.4"

Also fix an undefined variable error that was introduced in #92497
and has now been discovered by the updated phpstan version.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 69

  1. Benni Mack uploaded patch set 1 01/01/21, 15:05

  2. TYPO3com voted on patch set 1 V -1 01/01/21, 15:15 Completed build in 10m 17s on Fri, 1 Jan, 03:15 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8536

  3. Benni Mack uploaded patch set 2 01/01/21, 15:26

  4. Benjamin Franzke updated the commit message in patch set 3 01/01/21, 15:30

  5. TYPO3com voted on patch set 2 V +1 01/01/21, 15:37 Completed build in 11m 33s on Fri, 1 Jan, 03:37 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8537

  6. TYPO3com voted on patch set 3 V +1 01/01/21, 15:40 Completed build in 10m 06s on Fri, 1 Jan, 03:40 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8538

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 01/01/21, 16:59

  8. Benni Mack voted on patch set 3 V +2 CR +2 01/01/21, 17:01

  9. Benni Mack merged patch set 4 01/01/21, 17:01