Review main Merged

67325[BUGFIX] FormEngine does not edit workspace delete placeholders

Christian Kuhn CR +2 V +2 Normal +137 −7 updated 01/04/21, 18:46

Commit message

Workspace delete placeholders are just a marker that a
live record should be deleted in live when the delete
placeholder is published. Actual field data does not matter.
Those records should thus never be editable via FormEngine.

With patch, FormEngine throws an exception when a delete
placeholder is edited. Additionally, the module menu language
selector drop down when editing a record is adapted to not
link to delete placeholder workspace translations.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Christian Kuhn uploaded patch set 1 01/01/21, 16:54

  2. TYPO3com voted on patch set 1 V -1 01/01/21, 16:54 Completed build in 21s on Fri, 1 Jan, 04:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8541

  3. Christian Kuhn uploaded patch set 2 01/04/21, 11:47

  4. TYPO3com voted on patch set 2 V +1 01/04/21, 11:58 Completed build in 10m 19s on Mon, 4 Jan, 11:58 AM Test Summary: 32548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8585

  5. Benni Mack voted on patch set 2 CR +1 01/04/21, 14:02

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 01/04/21, 15:29

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 01/04/21, 18:46

  8. Anja Leichsenring merged patch set 3 01/04/21, 18:46