Review main Merged

67329[BUGFIX] Do not call "libxml_disable_entity_loader" in PHP 8

Benni Mack CR +2 V +2 Normal +69 −21 updated 01/04/21, 08:03

Commit message

Because the method (finally) is deprecated in PHP 8,
all calls in TYPO3 Core are wrapped in if statements
to avoid deprecation warnings.

PHP 8 effectively is more secure by default,
which is a good thing, but we need to consider this
in our code base, which still supports PHP 7
as well.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 58

  1. Benni Mack uploaded patch set 1 01/02/21, 20:55

  2. TYPO3com voted on patch set 1 V -1 01/02/21, 21:05 Completed build in 10m 06s on Sat, 2 Jan, 09:05 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8555

  3. TYPO3com commented on patch set 1 01/04/21, 07:16 Completed build in 10h 31m 25s on Mon, 4 Jan, 07:16 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8555

  4. Benni Mack uploaded patch set 2 01/04/21, 07:19

  5. Georg Ringer voted on patch set 2 V +1 CR +1 01/04/21, 07:22

  6. TYPO3com voted on patch set 2 V +1 01/04/21, 07:30 Completed build in 10m 37s on Mon, 4 Jan, 07:30 AM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8575

  7. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/04/21, 08:02

  8. Benjamin Franzke merged patch set 3 01/04/21, 08:03