Review main Merged

67331[BUGFIX] Remove duplicate error message in AjaxDataHandler

Simon Schaufelberger CR +2 V +2 Easy +3 −9 updated 01/11/21, 13:41

Commit message

When an error occurs in a DataHandler AJAX call, the error message
should only be shown once.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1115

  1. Simon Schaufelberger uploaded patch set 1 01/02/21, 22:48

  2. TYPO3com voted on patch set 1 V +1 01/02/21, 22:58 Completed build in 09m 44s on Sat, 2 Jan, 10:58 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8559

  3. Benjamin Franzke voted on patch set 1 CR +1 01/03/21, 05:47

  4. Benjamin Franzke commented on patch set 1 V -1 CR -1 01/04/21, 06:05

    It currently de-duplicates messages for hide/unhide, but not for delete. Fill fix.

    AjaxDataHandler.ts:244

    Here is another case, where a duplicate message is shown.
  5. Benjamin Franzke uploaded patch set 2 01/04/21, 06:09

  6. Benjamin Franzke commented on patch set 2 01/04/21, 06:09

    AjaxDataHandler.ts:244 Reply

    Done
  7. TYPO3com voted on patch set 2 V -1 01/04/21, 06:18 Completed build in 09m 46s on Mon, 4 Jan, 06:18 AM Test Summary: 1 of 32787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8571

  8. TYPO3com voted on patch set 2 V +1 01/04/21, 06:40 Completed build in 12m 19s on Mon, 4 Jan, 06:40 AM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8573

  9. Benjamin Franzke uploaded patch set 3 01/06/21, 15:04

    Rebase
  10. TYPO3com voted on patch set 3 V +1 01/06/21, 15:14 Completed build in 09m 47s on Wed, 6 Jan, 03:14 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8687

  11. Simon Schaufelberger commented on patch set 3 01/06/21, 15:19

    I'm aware of https://review.typo3.org/c/Packages/TYPO3.CMS/+/65612 but this other change seams more like a big refactoring while the current patch is just a quick fix.
  12. Benni Mack commented on patch set 3 01/06/21, 22:21

    Reply

    Let's have @olly also included in this review here.
  13. Andreas Kienast voted on patch set 3 V +2 CR +2 01/11/21, 06:45

  14. Andreas Kienast merged patch set 4 01/11/21, 06:45

  15. Oliver Hader voted on patch set 4 CR +1 01/11/21, 13:41