67331[BUGFIX] Remove duplicate error message in AjaxDataHandler
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1115
-
Simon Schaufelberger uploaded patch set 1 01/02/21, 22:48
-
TYPO3com voted on patch set 1 V +1 01/02/21, 22:58 Completed build in 09m 44s on Sat, 2 Jan, 10:58 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8559
-
Benjamin Franzke voted on patch set 1 CR +1 01/03/21, 05:47
-
Benjamin Franzke commented on patch set 1 V -1 CR -1 01/04/21, 06:05
It currently de-duplicates messages for hide/unhide, but not for delete. Fill fix.AjaxDataHandler.ts:244Here is another case, where a duplicate message is shown. -
Benjamin Franzke uploaded patch set 2 01/04/21, 06:09
-
Benjamin Franzke commented on patch set 2 01/04/21, 06:09
AjaxDataHandler.ts:244ReplyDone -
TYPO3com voted on patch set 2 V -1 01/04/21, 06:18 Completed build in 09m 46s on Mon, 4 Jan, 06:18 AM Test Summary: 1 of 32787 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8571
-
TYPO3com voted on patch set 2 V +1 01/04/21, 06:40 Completed build in 12m 19s on Mon, 4 Jan, 06:40 AM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8573
-
Benjamin Franzke uploaded patch set 3 01/06/21, 15:04
Rebase -
TYPO3com voted on patch set 3 V +1 01/06/21, 15:14 Completed build in 09m 47s on Wed, 6 Jan, 03:14 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8687
-
Simon Schaufelberger commented on patch set 3 01/06/21, 15:19
I'm aware of https://review.typo3.org/c/Packages/TYPO3.CMS/+/65612 but this other change seams more like a big refactoring while the current patch is just a quick fix. -
Benni Mack commented on patch set 3 01/06/21, 22:21
Reply
Let's have @olly also included in this review here. -
Andreas Kienast voted on patch set 3 V +2 CR +2 01/11/21, 06:45
-
Andreas Kienast merged patch set 4 01/11/21, 06:45
-
Oliver Hader voted on patch set 4 CR +1 01/11/21, 13:41