67333[BUGFIX] Do not process dumped file without cropping/sizing
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Josef Glatz +1
- Sebastian Michaelsen +1
- Guido Schmechel +1
- Wouter Wolters +1
-
Verified V +2 Done
- Georg Ringer +2
- Sebastian Michaelsen +1
- Guido Schmechel +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 2
Files 1
Review log 1724
-
Mathias Brodala uploaded patch set 1 01/04/21, 14:13
-
Mathias Brodala uploaded patch set 2 01/04/21, 14:15
-
Mathias Brodala updated the commit message in patch set 3 01/04/21, 14:21
-
TYPO3com voted on patch set 1 V +1 01/04/21, 14:23 Completed build in 10m 20s on Mon, 4 Jan, 02:23 PM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8591
-
TYPO3com voted on patch set 2 V +1 01/04/21, 14:27 Completed build in 11m 23s on Mon, 4 Jan, 02:27 PM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8592
-
TYPO3com voted on patch set 3 V +1 01/04/21, 14:32 Completed build in 11m 08s on Mon, 4 Jan, 02:32 PM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8593
-
Sebastian Michaelsen voted on patch set 3 CR +1 01/05/21, 07:11
-
Martin Kutschker commented on patch set 3 01/05/21, 09:54
Feature-90068-ImplementBetterFileDumpController.rst:74Is it ok to modify an old changelog entry? Seems strange to me. If this is not the first time, then ignore my comment. If it is, perhaps a "[fxed in 10.4.whatever]" note is appropriate. -
Mathias Brodala uploaded patch set 4 01/05/21, 10:19
-
Mathias Brodala commented on patch set 3 01/05/21, 10:21
FileDumpController.php:85ReplyYes, it's exactly like that. I've added the braces now nevertheless.Feature-90068-ImplementBetterFileDumpController.rst:74ReplyThis is actually a common action already done in previous changes. If someone objects I won't mind doing an Important.rst for this. -
TYPO3com voted on patch set 4 V +1 01/05/21, 10:31 Completed build in 10m 58s on Tue, 5 Jan, 10:30 AM Test Summary: 32543 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8616
-
Martin Kutschker commented on patch set 4 01/05/21, 12:35
Feature-90068-ImplementBetterFileDumpController.rst:74ReplyAck -
Martin Kutschker commented on patch set 4 CR -1 01/05/21, 15:57
FileDumpController.php:94UnresolvedThe new check ignores requests for image resizing. -
Mathias Brodala uploaded patch set 5 01/12/21, 15:08
-
TYPO3com voted on patch set 5 V +1 01/12/21, 15:18 Completed build in 10m 44s on Tue, 12 Jan, 03:18 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8834
-
Mathias Brodala rebased onto patch set 6 02/05/21, 08:11
-
TYPO3com voted on patch set 6 V +1 02/05/21, 08:22 Completed build in 10m 24s on Fri, 5 Feb, 08:22 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9278
-
core-ci voted on patch set 6 V +1 02/05/21, 08:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/396
-
Sebastian Michaelsen voted on patch set 6 V +1 CR +1 02/06/21, 08:45
-
Josef Glatz voted on patch set 6 CR +1 03/01/21, 14:45
-
Guido Schmechel voted on patch set 6 V +1 CR +1 03/01/21, 19:44
-
Wouter Wolters voted on patch set 6 CR +1 03/01/21, 21:38
-
Georg Ringer voted on patch set 6 V +2 CR +2 03/02/21, 20:16
-
Georg Ringer merged patch set 7 03/02/21, 20:16
FileDumpController.php:85