Review main Merged

67335[BUGFIX] Remove wrong data-formengine-input-name attribute

Andreas Kienast CR +2 V +2 Easy +1 −2 updated 01/04/21, 14:57

Commit message

With #93135, selectMultipleSideBySide fields broke and didn't accept new
values as both select fields share the same `data-formengine-input-name`
which confuses the changed CSS selector.

This patch removes the attribute from the "value provider" fields as
it's not required there at all and also adapt FormEngine to not
use the styling related form-select class.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 57

  1. Andreas Kienast uploaded patch set 1 01/04/21, 14:36

  2. Benjamin Franzke uploaded patch set 2 01/04/21, 14:41

  3. TYPO3com voted on patch set 1 V +1 01/04/21, 14:49 Completed build in 13m 09s on Mon, 4 Jan, 02:49 PM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8596

  4. Mathias Brodala voted on patch set 2 V +1 CR +1 01/04/21, 14:50

  5. TYPO3com voted on patch set 2 V +1 01/04/21, 14:57 Completed build in 13m 25s on Mon, 4 Jan, 02:57 PM Test Summary: 32546 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8597

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/04/21, 14:57

  7. Benjamin Franzke merged patch set 3 01/04/21, 14:57