Review main Abandoned

67340[BUGFIX] Load additional addRootLineFields in page tree context

Nicole Hummel CR 0 V 0 Easy +1 −1 updated 01/04/21, 22:50

Commit message

Page tree rows should be loaded with additional addRootLineFields to be
able to support further processing options in available hooks.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Nicole Hummel uploaded patch set 1 01/04/21, 17:01

  2. TYPO3com voted on patch set 1 V +1 01/04/21, 17:12 Completed build in 10m 17s on Mon, 4 Jan, 05:12 PM Test Summary: 32543 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8606

  3. Oli Bartsch commented on patch set 1 CR -1 01/04/21, 19:09

    TreeController.php:436

    The usage of this config seems wrong to me in that context. It's only meant for the rootline (RootlineUtility) which is actually the only place where it's currently evaluated. I agree that 3rd party would benefit from a more dynamic way but that IMO needs a new configuration option. Otherwise this would lead to unexpected behaviour especially when backporting. Furthermore one then would maybe expect that these fields are also available at other places where pages rows are accessible.
  4. Nicole Hummel commented on patch set 1 01/04/21, 20:45

    TreeController.php:436 Reply

    Hi Oliver, Would you mind to explain the difference between rootline and page tree to me? I have to admit that I expect both to load the same information. Furthermore the RootlineUtility is already in use in this class as well which consists in different data loaded.
  5. Benjamin Franzke commented on patch set 1 01/04/21, 21:34

    TreeController.php:436 Reply

    Hi Nicole, I agree with Olivers remarks and the proposed solution of using a designated option, if any. I think it would be strange to overload the term "addRootlineFields" into a general "pageFieldsOfGeneralInterest" thing. Why? Because not just rootLine fields may be of interest for hooks – but more. And then people start to add fields to the rootline, only to be able to process them for icon overlays.. But those data is never needed as part of the rootline, just as "current" page information, and that blows up the rootline. And, yes, RootlineUtility is already used, but for it's designated usecase, fetching data from the rootline. What do you think?
  6. Oli Bartsch commented on patch set 1 01/04/21, 21:38

    TreeController.php:436 Reply Unresolved

    Hey, for me, a rootline is only the "way" from a given site up to its root site while containing the parent sites on that "way". Whereas a tree contains of multiple root sites and ALL subpages (or a subset if somehow filtered). Furthermore it's the opposite direction => bottom-up while page tree ist top-down. As far as I can see, the RootlineUtility is only used once internally to get all root pages to assign background colors. No custom added fields are used and the result is not accessible in some way. The tree is not built using this utility but, among others, BackendUtility::BEgetRootLine(). As said in my first comment, I totally understand the benefit of defining custom fields for the pages rows in the page tree. But using this configuration option does not sound reasonable to me since it's only meant for the rootline utility and is currently only evaluated there. If introducing further usages of this configuration option, we would also need to adjust the configurations description and also add some RST to inform developers about it. Otherwise, as said, this could easily lead to unexpected behaviour.
  7. Nicole Hummel commented on patch set 1 01/04/21, 22:50

    My expectation is obviously different. I will not invest any time here. Just closing this one.
  8. Nicole Hummel abandoned the change 01/04/21, 22:50