Review 10.4 Merged

67341[BUGFIX] FormEngine does not edit workspace delete placeholders

Christian Kuhn CR +2 V +2 Normal +137 −7 updated 01/05/21, 10:00

Commit message

Workspace delete placeholders are just a marker that a
live record should be deleted in live when the delete
placeholder is published. Actual field data does not matter.
Those records should thus never be editable via FormEngine.

With patch, FormEngine throws an exception when a delete
placeholder is edited. Additionally, the module menu language
selector drop down when editing a record is adapted to not
link to delete placeholder workspace translations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 47

  1. Christian Kuhn uploaded patch set 1 01/04/21, 19:30

  2. TYPO3com voted on patch set 1 V -1 01/04/21, 19:42 Completed build in 12m 23s on Mon, 4 Jan, 07:42 PM Test Summary: 6 of 75765 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-955

  3. Christian Kuhn uploaded patch set 2 01/05/21, 09:37

  4. TYPO3com voted on patch set 2 V -1 01/05/21, 09:51 Completed build in 13m 06s on Tue, 5 Jan, 09:51 AM Test Summary: 1 of 75765 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-960

  5. TYPO3com voted on patch set 2 V +1 01/05/21, 09:54 Completed build in 29m 40s on Tue, 5 Jan, 09:54 AM Test Summary: 75280 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-960

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 01/05/21, 10:00

  7. Christian Kuhn merged patch set 3 01/05/21, 10:00