67342[BUGFIX] Working preview links in workspace mails
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 3
Files 5
- typo3/sysext/core/Documentation/Changelog/10.3/Feature-90411-HTML-basedWorkspaceNotificationEmailsOnStageChange.rst+0 −5
- typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php+12 −6
- typo3/sysext/workspaces/Resources/Private/Templates/Email/StageChangeNotification.html+1 −4
- typo3/sysext/workspaces/Resources/Private/Templates/Email/StageChangeNotification.txt+0 −1
- typo3/sysext/workspaces/ext_localconf.php+0 −1
Review log 79
-
Christian Kuhn uploaded patch set 1 01/05/21, 14:52
-
Christian Kuhn updated the commit message in patch set 2 01/05/21, 14:54
-
TYPO3com voted on patch set 1 V +1 01/05/21, 15:04 Completed build in 12m 05s on Tue, 5 Jan, 03:04 PM Test Summary: 32545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8626
-
TYPO3com voted on patch set 2 V +1 01/05/21, 15:07 Completed build in 12m 34s on Tue, 5 Jan, 03:07 PM Test Summary: 32545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8627
-
Oli Bartsch voted on patch set 2 V +1 CR +1 01/06/21, 14:21
-
Benni Mack commented on patch set 2 CR -1 01/06/21, 22:17
Nice one, could you also remove the comment in the Feature RST regarding the TSconfig toggle in the 90411 RST file? -
Christian Kuhn commented on patch set 2 01/07/21, 09:50
Reply Unresolved
I've read the .rst file twice now and don't understand what you mean. The mentioned toggle is removed with the patch already. Any pointers? -
Benni Mack commented on patch set 2 V +2 CR +2 01/07/21, 12:23
my bad. was "grep"ping the unpatched core -
Christian Kuhn merged patch set 3 01/07/21, 18:46