Review main Merged

67342[BUGFIX] Working preview links in workspace mails

Christian Kuhn CR +2 V +2 Easy +13 −17 updated 01/07/21, 18:46

Commit message

Fix a couple of issues with state change emails in
workspaces:

* We still can't deep link to the backend. The generated
  comparisonLink to the side-by-side preview module is a
  workspace backend functionality. The generated links
  don't work and show the login form. The fix is to
  generate "preview links" instead which call a frontend.
  We may be able to improve this later, when core v11
  allows deep linking.

* When changing the stage of a page delete placeholder
  - when a page is for deletion in live - preview link
  generation to these pages does not make sense, trying
  to generate such a link throws an exception "no
  connection to page tree", the ajax request fails and
  no mails are send. Fix is to catch the exception and
  leave out the link in the emails.

* Preview links did not carry the language id when
  sending notifications for state changes of non default
  language records. This is added to properly link to
  non-default language previews.

* A missing closing p-tag in the HTML mail.

* As a better default, preview links are now always added
  to the mails if possible. In rare cases where this is
  not wanted, the mail templates should be adapted.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 3

Files 5

Review log 79

  1. Christian Kuhn uploaded patch set 1 01/05/21, 14:52

  2. Christian Kuhn updated the commit message in patch set 2 01/05/21, 14:54

  3. TYPO3com voted on patch set 1 V +1 01/05/21, 15:04 Completed build in 12m 05s on Tue, 5 Jan, 03:04 PM Test Summary: 32545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8626

  4. TYPO3com voted on patch set 2 V +1 01/05/21, 15:07 Completed build in 12m 34s on Tue, 5 Jan, 03:07 PM Test Summary: 32545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8627

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 01/06/21, 14:21

  6. Benni Mack commented on patch set 2 CR -1 01/06/21, 22:17

    Nice one, could you also remove the comment in the Feature RST regarding the TSconfig toggle in the 90411 RST file?
  7. Christian Kuhn commented on patch set 2 01/07/21, 09:50

    Reply Unresolved

    I've read the .rst file twice now and don't understand what you mean. The mentioned toggle is removed with the patch already. Any pointers?
  8. Benni Mack commented on patch set 2 V +2 CR +2 01/07/21, 12:23

    my bad. was "grep"ping the unpatched core
  9. Christian Kuhn merged patch set 3 01/07/21, 18:46