Review main Merged

67343[TASK] Remove deprecated "route" argument from shortcut buttons

Oli Bartsch CR +2 V +2 Normal +15 −58 updated 01/06/21, 13:51

Commit message

With #93093 the shortcut PHP API was reworked.
Since then, providing the route path as "route"
argument is deprecated.

This patch removes all places in the core where
the argument was still being set.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 611

  1. Oli Bartsch uploaded patch set 1 01/05/21, 20:47

  2. TYPO3com voted on patch set 1 V -1 01/05/21, 20:59 Completed build in 11m 55s on Tue, 5 Jan, 08:59 PM Test Summary: 31829 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8652

  3. TYPO3com commented on patch set 1 01/05/21, 21:20 Completed build in 12m 47s on Tue, 5 Jan, 09:20 PM Test Summary: 1 of 30073 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8654

  4. TYPO3com commented on patch set 1 01/05/21, 21:36 Completed build in 10m 53s on Tue, 5 Jan, 09:36 PM Test Summary: 32097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8655

  5. TYPO3com voted on patch set 1 V +1 01/05/21, 21:42 Completed build in 47m 20s on Tue, 5 Jan, 09:42 PM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8654

  6. TYPO3com commented on patch set 1 01/05/21, 21:47 Completed build in 32m 46s on Tue, 5 Jan, 09:47 PM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8655

  7. Christian Kuhn voted on patch set 1 V +1 CR +1 01/06/21, 12:04

  8. Simon Gilli commented on patch set 1 V -1 CR +1 01/06/21, 13:20

    Looks good, testing the change now...
  9. Simon Gilli voted on patch set 1 V +1 01/06/21, 13:48

  10. Christian Kuhn voted on patch set 1 V +2 CR +2 01/06/21, 13:51

  11. Christian Kuhn merged patch set 2 01/06/21, 13:51