67346[BUGFIX] Fix requirejs-loader config and error handling
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Richard Haeser +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Richard Haeser +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 1013
-
Benjamin Franzke uploaded patch set 1 01/05/21, 23:23
-
TYPO3com voted on patch set 1 V -1 01/05/21, 23:45 Completed build in 17m 08s on Tue, 5 Jan, 11:45 PM Test Summary: 1 of 32798 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8666
-
TYPO3com voted on patch set 1 V +1 01/06/21, 05:54 Completed build in 10m 08s on Wed, 6 Jan, 05:54 AM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8669
-
Benjamin Franzke updated the commit message in patch set 2 01/06/21, 06:50
-
TYPO3com voted on patch set 2 V +1 01/06/21, 07:00 Completed build in 09m 59s on Wed, 6 Jan, 07:00 AM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8670
-
Benjamin Franzke commented on patch set 2 01/06/21, 07:47
Can be tested on the backend *login* page (where requirejs-loader.js is actually used) via browser javascript console: Good case for an existing ("nonpublic") module: window.require(['TYPO3/CMS/Dashboard/Grid'], (m) => console.log('should be called')); Error case (with proper propagation) for invalid module: window.require( ['invalid-module'], (m) => console.log('will not be called'), (e) => {console.error('error propagated: ' + e),console.log(e, e.originalError)} ); -
Benjamin Franzke commented on patch set 2 01/06/21, 07:49
Backport for 10.4, because of the error handling fixes. And the URL query string hardering doesn't hurt there as well. -
Richard Haeser voted on patch set 2 CR +1 01/06/21, 08:01
-
Richard Haeser voted on patch set 2 V +1 01/06/21, 08:07
-
Christian Kuhn voted on patch set 2 V +1 01/06/21, 11:58
-
Oli Bartsch voted on patch set 2 V +1 CR +1 01/06/21, 12:34
-
Benjamin Franzke voted on patch set 2 V +2 CR +2 01/06/21, 13:07
-
Benjamin Franzke merged patch set 3 01/06/21, 13:07