Review main Merged

67347[TASK] Streamline generated links to switch Backend user

Elias Häußler CR +2 V +2 Easy +8 −3 updated 01/06/21, 13:04

Commit message

Both links to switch Backend user (Backend toolbar item
and SwitchUser view helper) are now streamlined.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Elias Häußler uploaded patch set 1 01/06/21, 09:12

  2. TYPO3com voted on patch set 1 V +1 01/06/21, 09:22 Completed build in 09m 13s on Wed, 6 Jan, 09:22 AM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8673

  3. Christian Kuhn commented on patch set 1 01/06/21, 11:26

    SwitchUserViewHelper.php:74 Unresolved

    i guess we could actually keep the htmlspecialchars() - it won't harm.
  4. Christian Kuhn uploaded patch set 2 01/06/21, 11:26

  5. Elias Häußler commented on patch set 2 01/06/21, 11:34

    SwitchUserViewHelper.php:74

    Isn't it necessary here to cast `$uri` to string before doing `htmlspecialchars()`?
  6. TYPO3com voted on patch set 2 V +1 01/06/21, 11:43 Completed build in 12m 23s on Wed, 6 Jan, 11:43 AM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8678

  7. Christian Kuhn commented on patch set 2 01/06/21, 11:54

    SwitchUserViewHelper.php:74 Reply

    sure. we can do that to be more explicit.
  8. Christian Kuhn uploaded patch set 3 01/06/21, 11:55

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 01/06/21, 11:56

  10. TYPO3com voted on patch set 3 V +1 01/06/21, 12:07 Completed build in 09m 39s on Wed, 6 Jan, 12:07 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8682

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 01/06/21, 12:30

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 01/06/21, 13:03

  13. Christian Kuhn merged patch set 4 01/06/21, 13:04