Review main Merged

67349[BUGFIX] Fix collapsible elements in Backend User info

Elias Häußler CR +2 V +2 Easy +3 −3 updated 01/06/21, 16:15

Commit message

All collapsible elements in Backend User info (TSconfig,
exclude fields) can now be collapsed at first click. For
this, `aria-expanded="false"` has been set.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Elias Häußler uploaded patch set 1 01/06/21, 14:30

  2. TYPO3com voted on patch set 1 V +1 01/06/21, 14:43 Completed build in 12m 14s on Wed, 6 Jan, 02:43 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8685

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 01/06/21, 15:03

  4. Benjamin Franzke commented on patch set 1 V +2 CR +2 01/06/21, 15:48

    Hehe, hard to test, nonExcludeFields aren't actually rendered for backend user comparisons, and be_group comparison is currently broken ;) – created https://forge.typo3.org/issues/93233 for that. But yes, TSConfig works and the change for nonExcludeFields is correct (tested by enabling non exclude fields output for be users temporarily), therefore I'll merge this.
  5. Benjamin Franzke merged patch set 2 01/06/21, 15:48

  6. Elias Häußler commented on patch set 2 01/06/21, 16:15

    Reply

    Thanks for merging! You're right, I added the nonExcludeFields to the comparison view now in a separate patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67351