Review main Merged

67353[BUGFIX] Use PSR-17 interfaces in Extbase

Benjamin Franzke CR +2 V +2 Normal +32 −108 updated 02/08/21, 19:27

Commit message

In order to strengthen TYPO3's focus on PSR standards, this change
uses PSR-17 interfaces instead of the custom ResponseFactoryInterface
which was added solely for extbase in #92784.

The interface was added as part of the #92784 deprecation, but it
actually contradicts with the ideas of interchangable PSR interfaces
and therefore we strive for native PSR-17 usage, instead of wrapping
PSR interfaces, now.
The Extbase ActionController::htmlResponse() method – which was
suggested to be used by #92784 – is kept as is (functionality wise [1]),
and since the interface was injected into the ActionController using a
final method, the impact of this switch is very low.

Concrete implementations of PSR interfaces are always internal api,
threfore also TYPO3\CMS\Core\Http\Response is switched back to be
marked as internal API.

Furthermore TYPO3\CMS\Core\Http\JsonResponse properties do not need to
be marked internal, as the entire class is internal.

[1] ActionController::htmlResponse() is adapted to avoid rewinding()
    the response body, as every usage/respond is actually expected
    to rewind or use toString(), and therefore rewind() would be
    called twice. Only functional tests where buggy in not calling
    rewind() during test assertion.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 10

Review log 1014

  1. Benjamin Franzke uploaded patch set 1 01/06/21, 17:12

  2. TYPO3com voted on patch set 1 V -1 01/06/21, 17:22 Completed build in 10m 10s on Wed, 6 Jan, 05:22 PM Test Summary: 15 of 32795 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8693

  3. Benjamin Franzke uploaded patch set 2 01/06/21, 17:34

  4. TYPO3com voted on patch set 2 V +1 01/06/21, 17:44 Completed build in 09m 50s on Wed, 6 Jan, 05:44 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8695

  5. Benjamin Franzke uploaded patch set 3 01/06/21, 22:03

  6. TYPO3com voted on patch set 3 V +1 01/06/21, 22:18 Completed build in 13m 57s on Wed, 6 Jan, 10:18 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8707

  7. Benjamin Franzke uploaded patch set 4 01/06/21, 22:23

  8. TYPO3com voted on patch set 4 V +1 01/06/21, 22:34 Completed build in 11m 23s on Wed, 6 Jan, 10:34 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8708

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 01/07/21, 13:30

  10. Oli Bartsch voted on patch set 4 V +1 CR +1 01/07/21, 13:38

  11. Benjamin Franzke voted on patch set 4 V +2 CR +2 01/07/21, 13:43

  12. Benjamin Franzke merged patch set 5 01/07/21, 13:46

  13. Alexander Schnitzler commented on patch set 5 01/07/21, 15:08

    Hey, can you please add the extbase tag to this patch? It helps me gather all patches to create a summary for talks. Also, feel free to add me in cc in Extbase patches to keep me informed if things are changed. Thanks.
  14. Benjamin Franzke commented on patch set 5 02/08/21, 19:27

    Reply

    Sorry, too late, a topic cannot be added after merge.