Review main Merged

67354[BUGFIX] Never show deleted users in compare view

Christian Kuhn CR +2 V +2 Easy +3 −4 updated 01/06/21, 22:18

Commit message

Adding a user to the ext:beuser 'compare' list and
deleting the user afterwards, still allows to compare
that user with others.
Fix the repository query settings to never handle
deleted users.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Kuhn uploaded patch set 1 01/06/21, 17:42

  2. Oli Bartsch uploaded patch set 2 01/06/21, 17:44

  3. Oli Bartsch voted on patch set 2 V +1 CR +1 01/06/21, 17:44

  4. TYPO3com voted on patch set 1 V -1 01/06/21, 17:51 Completed build in 08m 54s on Wed, 6 Jan, 05:51 PM Test Summary: 10 of 32806 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8696

  5. TYPO3com voted on patch set 2 V +1 01/06/21, 17:54 Completed build in 10m 37s on Wed, 6 Jan, 05:54 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8697

  6. Benni Mack voted on patch set 2 V +2 CR +2 01/06/21, 22:18

  7. Benni Mack merged patch set 3 01/06/21, 22:18