Review main Merged

67355[TASK] Fetch route from request instead of GET parameter

Oli Bartsch CR +2 V +2 Normal +87 −41 updated 01/11/21, 12:24

Commit message

The "route" GET parameter is deprecated since #93048.
Therefore the route path has now to be fetched from the
request object instead.

This patch replaces all places in core where the route
is still fetched via GET. It's currently often necessary
to access $GLOBALS['TYPO3_REQUEST'] therefore, since the
request object is not always present at those places. This
will be tackeled in upcoming patches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1119

  1. Oli Bartsch uploaded patch set 1 01/06/21, 19:17

  2. TYPO3com voted on patch set 1 V -1 01/06/21, 19:17 Completed build in 23s on Wed, 6 Jan, 07:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8701

  3. Oli Bartsch uploaded patch set 2 01/06/21, 20:03

  4. TYPO3com voted on patch set 2 V -1 01/06/21, 20:13 Completed build in 10m 19s on Wed, 6 Jan, 08:13 PM Test Summary: 8 of 32806 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8702

  5. Oli Bartsch uploaded patch set 3 01/07/21, 10:10

  6. TYPO3com voted on patch set 3 V +1 01/07/21, 10:32 Completed build in 13m 11s on Thu, 7 Jan, 10:32 AM Test Summary: 32567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8726

  7. Christian Kuhn commented on patch set 3 CR -1 01/07/21, 12:37

    will be updated by oli soon.
  8. Oli Bartsch uploaded patch set 4 01/07/21, 13:15

  9. TYPO3com voted on patch set 4 V -1 01/07/21, 13:15 Completed build in 25s on Thu, 7 Jan, 01:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8731

  10. Oli Bartsch uploaded patch set 5 01/07/21, 13:21

  11. TYPO3com voted on patch set 5 V -1 01/07/21, 13:31 Completed build in 09m 32s on Thu, 7 Jan, 01:31 PM Test Summary: 16 of 32808 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8732

  12. TYPO3com commented on patch set 5 01/07/21, 13:42 Completed build in 29m 49s on Thu, 7 Jan, 01:42 PM Test Summary: 16 of 32808 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8732

  13. Oli Bartsch uploaded patch set 6 01/07/21, 14:29

  14. TYPO3com voted on patch set 6 V -1 01/07/21, 14:40 Completed build in 10m 36s on Thu, 7 Jan, 02:39 PM Test Summary: 1 of 32808 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8736

  15. TYPO3com voted on patch set 6 V +1 01/07/21, 14:47 Completed build in 28m 40s on Thu, 7 Jan, 02:47 PM Test Summary: 32567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8736

  16. Christian Kuhn voted on patch set 6 V +1 CR +1 01/07/21, 15:08

  17. Benni Mack voted on patch set 6 V +2 CR +2 01/07/21, 19:18

  18. Benni Mack merged patch set 7 01/07/21, 19:18

  19. Oliver Hader voted on patch set 7 CR +1 01/11/21, 12:24