Review 10.4 Merged

67356[BUGFIX] FormEngine: Fix several validation issues in complex field types

Andreas Kienast CR +2 V +2 Easy +23 −18 updated 01/09/21, 09:33

Commit message

The FormEngine field type `selectMutlipleSideBySide` is very special, as
it's a combination of four input and select fields. With the refactoring
done in #87324 an issue in the validation has been introduced which
caused the validation of the wrong field which contains no validation
rules. This patch uses the correct field to obtain the validation rules
from, now.

Another issue is that values of `selectCheckBox` never have been
validated as the necessary validation rules were missing. The rules are
now appended to the outermost div container. In the same run, minor
styling and markup changes were necessary.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 2

Files 7

Review log 35

  1. Andreas Kienast uploaded patch set 1 01/07/21, 06:52

  2. TYPO3com voted on patch set 1 V -1 01/07/21, 07:06 Completed build in 13m 38s on Thu, 7 Jan, 07:06 AM Test Summary: 9 of 75789 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-970

  3. TYPO3com voted on patch set 1 V +1 01/07/21, 07:51 Completed build in 1h 12m 48s on Thu, 7 Jan, 07:51 AM Test Summary: 75304 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-970

  4. Richard Haeser voted on patch set 1 V +2 CR +2 01/09/21, 09:33

  5. Richard Haeser merged patch set 2 01/09/21, 09:33