Review main Merged

67357[BUGFIX] Use absolute path for media files in backend

Oli Bartsch CR +2 V +2 Easy +37 −10 updated 01/08/21, 19:20

Commit message

Since #93048 using relative paths in backend does not
longer work in most cases. Therefore the MediaRenderers
should always use absoulte paths when in backend context.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 913

  1. Oli Bartsch uploaded patch set 1 01/07/21, 12:50

  2. TYPO3com voted on patch set 1 V +1 01/07/21, 13:00 Completed build in 09m 47s on Thu, 7 Jan, 01:00 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8730

  3. Oli Bartsch uploaded patch set 2 01/08/21, 10:37

  4. TYPO3com voted on patch set 2 V +1 01/08/21, 10:48 Completed build in 11m 32s on Fri, 8 Jan, 10:48 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8755

  5. Guido Schmechel commented on patch set 2 01/08/21, 11:03

    VideoTagRenderer.php:130

    Can you maybe outsource this code as a private/protected function? In https://review.typo3.org/c/Packages/TYPO3.CMS/+/66214 I also have the problem with the tracks and would have several requests.
  6. Oli Bartsch uploaded patch set 3 01/08/21, 12:06

  7. Oli Bartsch commented on patch set 3 01/08/21, 12:08

    VideoTagRenderer.php:130 Reply

    Done
  8. TYPO3com voted on patch set 3 V -1 01/08/21, 12:17 Completed build in 10m 35s on Fri, 8 Jan, 12:17 PM Test Summary: 32220 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8758

  9. TYPO3com voted on patch set 3 V +1 01/08/21, 12:34 Completed build in 09m 29s on Fri, 8 Jan, 12:34 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8759

  10. Guido Schmechel commented on patch set 3 V +1 CR +1 01/08/21, 12:42

    Verified with v11
  11. Christian Kuhn voted on patch set 3 V +1 CR +1 01/08/21, 17:36

  12. Benni Mack voted on patch set 3 V +2 CR +2 01/08/21, 19:20

  13. Benni Mack merged patch set 4 01/08/21, 19:20