Review main Merged

67358[BUGFIX] Suppress warning in SimpleFileBackend unlink()

Christian Kuhn CR +2 V +2 Easy +1 −6 updated 01/07/21, 15:05

Commit message

Calling $cache->remove() on a simple file backend when
the file does not exist leads to a PHP warning.
Checking with file_exists() before could lead to race
conditions if some other process unlinks in between.
Solution is to simply suppress the unlink warning.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 01/07/21, 14:36

  2. TYPO3com voted on patch set 1 V +1 01/07/21, 14:45 Completed build in 09m 20s on Thu, 7 Jan, 02:45 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8737

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 01/07/21, 14:46

  4. Benjamin Franzke voted on patch set 1 CR +1 01/07/21, 14:51

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 01/07/21, 15:05

  6. Benjamin Franzke merged patch set 2 01/07/21, 15:05