Review main Merged

67362[BUGFIX] Fix several issues with collapse elements

Oli Bartsch CR +2 V +2 Easy +8 −9 updated 01/08/21, 19:24

Commit message

Since bootstrap v5 the collapse JavaScript plugin
is using `collapse.show` instead of `collapse.in`
as the expanded state class.

Since TYPO3 added custom styles based on the
`.in` class, several modules did not longer work.
This is now fixed by using the correct class.

Additionally the workspace record collapse state
identifier icon now reflects the current state again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 56

  1. Oli Bartsch uploaded patch set 1 01/08/21, 10:27

  2. TYPO3com voted on patch set 1 V +1 01/08/21, 10:36 Completed build in 09m 36s on Fri, 8 Jan, 10:36 AM Test Summary: 32567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8754

  3. Guido Schmechel voted on patch set 1 V +1 01/08/21, 13:52

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 01/08/21, 17:25

  5. Benni Mack voted on patch set 1 V +2 CR +2 01/08/21, 19:24

  6. Benni Mack merged patch set 2 01/08/21, 19:24