Review main Merged

67363[TASK] Display user and group names completely

Guido Schmechel CR +2 V +2 Easy +4 −2 updated 01/18/21, 10:22

Commit message

User and group names in the access module are no longer shortened
after 20 characters. It is now possible to see the full 50 characters.

In addition, a title attribute has been added.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1115

  1. Guido Schmechel uploaded patch set 1 01/08/21, 11:46

  2. Guido Schmechel updated the commit message in patch set 2 01/08/21, 11:47

  3. TYPO3com voted on patch set 1 V +1 01/08/21, 11:56 Completed build in 09m 34s on Fri, 8 Jan, 11:56 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8756

  4. TYPO3com voted on patch set 2 V +1 01/08/21, 11:58 Completed build in 10m 56s on Fri, 8 Jan, 11:58 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8757

  5. Guido Schmechel commented on patch set 2 01/08/21, 12:51

    Is that OK as it is, or do we still need text-overflow: ellipsis as a supplement? Keyword: Responsive Do we need anything else regarding accessibility? (aria-label?)
  6. Oli Bartsch commented on patch set 2 01/08/21, 13:05

    Reply

    I think if we are already one it, we should use buttons instead of a tags, since they are no links. They actually miss the href attribute completely.
  7. Guido Schmechel commented on patch set 2 01/09/21, 12:49

    Reply

    We can do that. If I change it to a simple button, it just looks ugly ;-) Are there any interesting CSS classes that make a button look like a link?
  8. Jörg Bösche updated the commit message in patch set 3 01/09/21, 22:28

  9. TYPO3com voted on patch set 3 V -1 01/09/21, 22:38 Completed build in 10m 00s on Sat, 9 Jan, 10:38 PM Test Summary: 10 of 32810 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8783

  10. Richard Haeser commented on patch set 3 01/10/21, 03:47

    Reply

    It is not a button either isn't it? Or at least it is not styled like a button. Not sure about accessibility reasons for that. So maybe that is something we need to check, or leave it for now. I would opt for the text-overflow style as long as we have the title, this should be ok.
  11. TYPO3com voted on patch set 3 V +1 01/15/21, 20:36 Completed build in 09m 36s on Fri, 15 Jan, 08:36 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8870

  12. Guido Schmechel commented on patch set 3 01/15/21, 20:36

    Reply

    If you click on the name, a select box appears and you can change the option and save it. According to the definition, it would be more like a button, wouldn't it? If we change to a button, it requires more CSS changes. I'm also not really suited for the topic of CSS ;-)
  13. Oli Bartsch commented on patch set 3 V +1 CR +1 01/18/21, 09:17

    Reply Unresolved

    Yes, I had a look. There are still a lot of wrong a tags. IMO thats not the topic of this patch. Will create a dedicated patch for the buttons instead.
  14. Benni Mack voted on patch set 3 V +2 CR +2 01/18/21, 10:22

  15. Benni Mack merged patch set 4 01/18/21, 10:22