67365[TASK] Check maximum PHP version in entrypoints
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 4
Review log 2632
Show 67 earlier messages
-
Mathias Brodala uploaded patch set 1 01/08/21, 15:09
-
TYPO3com voted on patch set 1 V +1 01/08/21, 15:19 Completed build in 10m 08s on Fri, 8 Jan, 03:19 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8767
-
Simon Gilli commented on patch set 1 01/08/21, 15:32
-
Simon Gilli commented on patch set 1 01/08/21, 15:34
-
Mathias Brodala commented on patch set 1 01/08/21, 15:45
backend.php:17ReplyThen we must use version_compare() and define two custom constants which are then globally available within TYPO3. My current status is that TYPO3 tries to get rid of all custom global constants ... -
Christian Kuhn commented on patch set 1 01/08/21, 16:03
backend.php:17ReplyNo new constants in this global context, please keep this straight. -
Oliver Klee voted on patch set 1 CR +1 01/09/21, 00:30
-
Helmut Hummel commented on patch set 1 CR -1 01/09/21, 23:58
Let me check first whether I can come up with an alternative solution for this. -
Helmut Hummel commented on patch set 1 01/10/21, 00:18
Here is my alternative solution: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67371 Composer platform check also still miss upper bound check, but I created a feature request for that: https://github.com/composer/composer/issues/9596 In any case I think it make sense to remove our own checks altogether and rely on Composer for that. -
Simon Gilli commented on patch set 1 01/10/21, 09:09
Reply Unresolved
Lets take your solution for master and this one for v10. -
Mathias Brodala commented on patch set 1 01/11/21, 07:29
backend.php:17ReplyDone -
Mathias Brodala uploaded patch set 2 01/11/21, 07:48
-
Mathias Brodala commented on patch set 2 01/11/21, 07:48
Added missing "install.php" change. -
TYPO3com voted on patch set 2 V +1 01/11/21, 07:58 Completed build in 10m 26s on Mon, 11 Jan, 07:58 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8802
-
Daniel Siepmann commented on patch set 2 01/11/21, 11:50
As far as I understood, we also would need to adjust https://github.com/TYPO3/cms-cli/blob/2.0.0/typo3 ? At least `./vendor/bin/typo3 scheduler:run` will be executed by that binary, which is more or less independent of actual TYPO3 and the version constraints? With this patch I still get an incompatible error when executing the scheduler for 10.4 with PHP 8.0. -
Mathias Brodala commented on patch set 2 01/11/21, 11:54
Reply Unresolved
Yes, all external/3rd party packages which provide their own entrypoints would need to be adjusted. -
Mathias Brodala rebased onto patch set 3 02/05/21, 08:11
-
TYPO3com voted on patch set 3 V +1 02/05/21, 08:26 Completed build in 14m 19s on Fri, 5 Feb, 08:26 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9279
-
core-ci voted on patch set 3 V +1 02/05/21, 08:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/397
-
Jörg Bösche voted on patch set 3 CR +1 02/11/21, 19:09
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 03/02/21, 19:08
-
Christian Kuhn commented on patch set 3 CR -1 03/02/21, 19:55
sure we still need this in master, since we're fixing php 8 currently and composer.json allows it already? -
Mathias Brodala commented on patch set 3 03/03/21, 07:36
Reply Unresolved
Yes, but then adjusted to prevent PHP 9. -
Christian Kuhn commented on patch set 3 03/26/21, 08:56
Mathias, would you like to update the patch again, so we get it done? -
Mathias Brodala uploaded patch set 4 03/26/21, 09:00
-
Mathias Brodala commented on patch set 4 03/26/21, 09:02
Reply
Done now by switching to PHP 9 -
TYPO3com voted on patch set 4 V +1 03/26/21, 09:06 Completed build in 05m 47s on Fri, 26 Mar, 09:06 AM Test Summary: 33239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10357
-
core-ci voted on patch set 4 V +1 03/26/21, 09:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1847
-
Christian Kuhn voted on patch set 4 V +1 CR +1 03/26/21, 10:03
-
Oli Bartsch voted on patch set 4 V +1 CR +1 03/26/21, 14:46
-
Christian Kuhn voted on patch set 4 V +2 CR +2 03/26/21, 14:50
-
Christian Kuhn merged patch set 5 03/26/21, 14:50
backend.php:17