Review main Merged

67368[TASK] Separate restore from delete in DataHandler

Christian Kuhn CR +2 V +2 Hard +186 −80 updated 01/11/21, 20:24

Commit message

The DataHandler delete related methods still handle
too many things.
This is yet another divide & conquer patch: Move
the 'undelete' functionality to dedicated methods,
drop handling from 'delete' methods and refactor
'undelete'.
The result is a quite straight forward 'undelete'
implementation, plus reduced complexity in 'delete'.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 69

  1. Christian Kuhn uploaded patch set 1 01/09/21, 15:57

  2. TYPO3com voted on patch set 1 V +1 01/09/21, 16:09 Completed build in 11m 12s on Sat, 9 Jan, 04:09 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8778

  3. Christian Kuhn uploaded patch set 2 01/09/21, 17:31

  4. TYPO3com voted on patch set 2 V +1 01/09/21, 17:42 Completed build in 10m 53s on Sat, 9 Jan, 05:42 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8780

  5. Oli Bartsch uploaded patch set 3 01/11/21, 16:32

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 01/11/21, 16:42

  7. TYPO3com voted on patch set 3 V +1 01/11/21, 16:43 Completed build in 10m 26s on Mon, 11 Jan, 04:43 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8810

  8. Benni Mack voted on patch set 3 V +2 CR +2 01/11/21, 20:24

  9. Benni Mack merged patch set 4 01/11/21, 20:24