Review main Merged

67369[BUGFIX] Hide deleted flexform section in DOM

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 01/11/21, 19:36

Commit message

If a Flexform section gets deleted, the container must be hidden in DOM
and not deleted, as the underlying DataHandler code relies on getting
the field submitted.

This patch is less intrusive as possible to allow a backport to stable
releases. Flexforms needs a major refactoring and should act similar to
IRRE, but this can go into the master branch only.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Martin Kutschker +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Martin Kutschker +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1218

  1. Andreas Kienast uploaded patch set 1 01/09/21, 16:43

  2. TYPO3com voted on patch set 1 V -1 01/09/21, 16:51 Completed build in 08m 50s on Sat, 9 Jan, 04:51 PM Test Summary: 1 of 29270 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8779

  3. TYPO3com commented on patch set 1 01/09/21, 17:00 Completed build in 26m 21s on Sat, 9 Jan, 05:00 PM Test Summary: 1 of 32810 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8779

  4. TYPO3com voted on patch set 1 V +1 01/09/21, 17:25 Completed build in 1h 08m 56s on Sat, 9 Jan, 05:25 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8779

  5. Martin Kutschker commented on patch set 1 01/09/21, 20:32

    FormEngineFlexForm.ts:130

    Does it make sense to set the style directly without CSS classes to make sure it is and stays hidden?
  6. Andreas Kienast commented on patch set 1 01/09/21, 20:45

    FormEngineFlexForm.ts:130 Reply

    using .hide() should ne fine as well
  7. Richard Haeser uploaded patch set 2 01/10/21, 00:16

  8. Richard Haeser commented on patch set 2 01/10/21, 00:17

    FormEngineFlexForm.ts:130 Reply

    Done
  9. Richard Haeser voted on patch set 2 V +1 CR +1 01/10/21, 00:17

  10. TYPO3com voted on patch set 2 V -1 01/10/21, 00:28 Completed build in 11m 11s on Sun, 10 Jan, 12:28 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8785

  11. Richard Haeser uploaded patch set 3 01/10/21, 00:47

  12. TYPO3com commented on patch set 2 01/10/21, 00:47 Completed build in 11m 38s on Sun, 10 Jan, 12:47 AM Test Summary: 1 of 32810 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8789

  13. TYPO3com voted on patch set 3 V +1 01/10/21, 00:58 Completed build in 10m 53s on Sun, 10 Jan, 12:58 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8790

  14. Richard Haeser voted on patch set 3 V +1 CR +1 01/10/21, 00:58

  15. Martin Kutschker voted on patch set 3 V +1 CR +1 01/10/21, 09:50

  16. Oliver Hader voted on patch set 3 CR +1 01/11/21, 13:40

  17. Richard Haeser voted on patch set 3 V +2 CR +2 01/11/21, 19:36

  18. Richard Haeser merged patch set 4 01/11/21, 19:36