67371[TASK] Use Composer runtime platform check instead of our own
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Benni Mack +2
- Simon Gilli +1
- Markus Klein +1
- Christian Kuhn +1
- Xavier Perseguers +1
- Mathias Brodala +1
-
Verified V +2 Done
- Helmut Hummel +2
- Benni Mack +2
- Simon Gilli +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Resources/Private/Php/backend.php+0 −5
- typo3/sysext/core/Resources/Private/Php/cli.php+0 −5
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/frontend/Resources/Private/Php/frontend.php+0 −5
- typo3/sysext/install/Resources/Private/Php/install.php+0 −5
- composer.json+1 −1
- composer.lock+4 −5
Review log 4249
Show 2024 earlier messages
-
Helmut Hummel uploaded patch set 1 01/10/21, 00:16
-
Helmut Hummel updated the commit message in patch set 2 01/10/21, 00:19
-
Helmut Hummel updated the commit message in patch set 3 01/10/21, 00:21
-
Richard Haeser commented on patch set 3 01/10/21, 00:30
Seems nice! As I'm not that into the runtime platform check, does this still work when you have a non-composer-based installation? -
TYPO3com voted on patch set 1 V +1 01/10/21, 00:33 Completed build in 16m 34s on Sun, 10 Jan, 12:33 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8786
-
TYPO3com voted on patch set 2 V +1 01/10/21, 00:39 Completed build in 12m 13s on Sun, 10 Jan, 12:39 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8787
-
TYPO3com voted on patch set 3 V +1 01/10/21, 00:43 Completed build in 16m 12s on Sun, 10 Jan, 12:43 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8788
-
Simon Gilli voted on patch set 3 CR +1 01/10/21, 09:05
-
Simon Gilli commented on patch set 3 01/10/21, 09:46
Reply
Yes. Finally it's all Composer, one managed by the core, the other managed by the user directly. -
Simon Gilli commented on patch set 3 01/10/21, 09:58
Lower bound check works correctly and shows a useful merror message. Because of the platform.php value no error is shown during composer runtime, is this what we want? -
Mathias Brodala commented on patch set 3 01/11/21, 07:29
Shouldn't we include cli.php too like in https://review.typo3.org/c/Packages/TYPO3.CMS/+/67365 ? -
Simon Gilli commented on patch set 3 01/11/21, 11:14
Reply
Everything which uses the vendor/autoload.php will have the check included automatically. -
Mathias Brodala commented on patch set 3 01/11/21, 11:22
Reply
Ah yes, of course. In this case it makes sense that cli.php is left unchanged since it's missing the version check so far. -
Mathias Brodala commented on patch set 3 V -1 CR +1 01/11/21, 11:35
Works with PHP 7.2: > Fatal error: Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 7.4.0". You are running 7.2.30-1+ubuntu18.04.1+deb.sury.org+1. in /.../vendor/composer/platform_check.php on line 24 Fails with PHP 8.0: > Fatal error: Uncaught TYPO3\CMS\Core\Error\Exception: PHP Warning: Undefined array key "type" in /.../typo3/sysext/core/Classes/Error/DebugExceptionHandler.php line 418 in /.../typo3/sysext/core/Classes/Error/ErrorHandler.php:133 Stack trace: #0 /.../typo3/sysext/core/Classes/Error/DebugExceptionHandler.php(418): TYPO3\CMS\Core\Error\ErrorHandler->handleError(2, 'Undefined array...', '/var/www/html/m...', 418) #1 /.../typo3/sysext/core/Classes/Error/DebugExceptionHandler.php(167): TYPO3\CMS\Core\Error\DebugExceptionHandler->getBacktraceCode(Array) #2 /.../typo3/sysext/core/Classes/Error/DebugExceptionHandler.php(97): TYPO3\CMS\Core\Error\DebugExceptionHandler->getSingleThrowableContent(Object(TYPO3\CMS\Core\Error\Exception), 1, 1) #3 /.../typo3/sysext/core/Classes/Error/DebugExceptionHandler.php(47): TYPO3\CMS\Core\Error\DebugExceptionHandler->getContent(Object(TYPO3\CMS\Core\Error\Exception)) #4 /.../typo3/sysext/core/Classes/Error/AbstractExceptionHandler.php(56): TYPO3\CMS\Core\Error\DebugExceptionHandler->echoExceptionWeb(Object(TYPO3\CMS\Core\Error\Exception)) #5 [internal function]: TYPO3\CMS\Core\Error\AbstractExceptionHandler->handleException(Object(TYPO3\CMS\Core\Error\Exception)) #6 {main} thrown in /.../typo3/sysext/core/Classes/Error/ErrorHandler.php on line 133 This was already reported by Helmut: https://github.com/composer/composer/issues/9596 -
Simon Gilli commented on patch set 3 01/11/21, 11:52
Reply Unresolved
Yes, as said by Helmut before the upper check is missing currently. I see you found the related composer issue. -
Simon Gilli commented on patch set 3 01/11/21, 11:54
Another side note: we should wait with this patch until composer/installers v2 is released. See also https://github.com/composer/installers/issues/470. -
Simon Gilli commented on patch set 3 01/11/21, 12:07
The missing link to Composer https://github.com/composer/composer/issues/9596 -
Simon Gilli updated the commit message in patch set 4 01/11/21, 12:08
-
Simon Gilli voted on patch set 4 V -1 CR +1 01/11/21, 12:09
-
TYPO3com voted on patch set 4 V +1 01/11/21, 12:18 Completed build in 10m 16s on Mon, 11 Jan, 12:18 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8807
-
Helmut Hummel commented on patch set 4 01/11/21, 14:24
How does this relate to composer/installers? Why did you vote -1 verified? What exactly does not work? -
Mathias Brodala commented on patch set 4 01/11/21, 14:31
Reply
Answering on my behalf: I did vote V-1 in light of https://forge.typo3.org/issues/93246 but I just noticed that you have created a separate ticket with a different topic. -
Mathias Brodala commented on patch set 4 V -1 01/15/21, 15:41
As mentioned before: my original intention (prevent execution on PHP 8) is not solved by this. Also in the meantime https://github.com/composer/composer/issues/9596 has been rejected so I think we need to continue with our custom check instead. -
Simon Gilli commented on patch set 4 V 0 01/15/21, 15:44
Reply Unresolved
Increasing the req to Composer 2 will make some packages unusable because of the linked issue of composer/installers. The -1 vote was just because of Mathias' vote before which he already explained and which was removed by my change in the commit message.
-
Helmut Hummel uploaded patch set 5 07/21/21, 11:35
-
core-ci voted on patch set 5 V +1 07/21/21, 11:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13621
-
Xavier Perseguers commented on patch set 5 07/21/21, 12:04
Unresolved
fauling => failing -
Benni Mack commented on patch set 5 07/21/21, 12:05
Nice work. Should we go with 2.1.0 instead? seeing the composer.lock used the composer-runtime-version 2.1 already. -
Benni Mack commented on patch set 5 07/21/21, 12:06
Reply
is this still a problem for us? -
Simon Gilli commented on patch set 5 07/21/21, 12:43
Reply
Yes, as long as there is no v2 release for the composer/installers package or Aimeos doesn't provide a separate installer there will still be an issue. -
Simon Gilli voted on patch set 5 CR +1 07/21/21, 13:18
-
Markus Klein commented on patch set 5 CR +1 07/21/21, 14:06
makes sense to me -
Christian Kuhn commented on patch set 5 07/21/21, 16:37
[FEATURE] seems a bit misleading and should have a feature.rst. Make it [TASK] instead? -
Christian Kuhn updated the commit message in patch set 6 07/21/21, 16:40
-
core-ci voted on patch set 6 V +1 07/21/21, 16:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13638
-
Xavier Perseguers commented on patch set 6 CR -1 07/21/21, 18:04
Since commit message was updated but my (small) comment forgotten, adding a -1 to make it more visible :) -
Christian Kuhn updated the commit message in patch set 7 07/21/21, 21:06
-
Christian Kuhn commented on patch set 7 07/21/21, 21:07
Reply
Edited the commit message for you convenience, Xavier. -
core-ci voted on patch set 7 V +1 07/21/21, 21:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/13641
-
Xavier Perseguers commented on patch set 7 CR +1 07/22/21, 05:11
Thx Lolli 😉 -
Markus Klein voted on patch set 7 CR +1 07/22/21, 06:19
-
Christian Kuhn voted on patch set 7 V +1 CR +1 07/22/21, 09:53
-
Helmut Hummel commented on patch set 7 07/22/21, 17:03
Reply
I think it would make sense to use 2.1 once we rely on 2.1 runtime features, which this change does not introduce yet -
Benni Mack commented on patch set 7 V +2 CR +2 07/26/21, 13:35
@simongilli: Composer Installers 2.0 is on the way, I think we can continue here. -
Mathias Brodala voted on patch set 7 CR +1 07/26/21, 13:38
-
Simon Gilli commented on patch set 7 V +1 CR +1 07/26/21, 16:08
Reply
Alpha is out now see https://github.com/composer/installers/issues/470. So the issue should be solved very soon. -
Simon Gilli commented on patch set 7 07/26/21, 16:09
Reply
Yes agree. Also posted now, didn't see your comment before. -
Helmut Hummel voted on patch set 7 V +2 CR +2 07/26/21, 16:36
-
Helmut Hummel merged patch set 8 07/26/21, 16:36