Review 10.4 Merged

67373[TASK] Blind more configuration options per default

Benni Mack CR +2 V +2 Easy +13 −0 updated 01/08/21, 21:38

Commit message

TYPO3 should blind sensitive configurations options, such
as credentials or keys, by default, since the configuration
module can usually be accessed by all admins.

Integrators always have the possibility to adjust these
settings using the modifyBlindedConfigurationOptions
hook.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 59

  1. Benni Mack commented on patch set 1 01/08/21, 19:56

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/lowlevel/Classes/ConfigurationModuleProvider/GlobalVariableProvider.php
  2. TYPO3com voted on patch set 1 V -1 01/08/21, 19:56 Completed build in 26s on Fri, 8 Jan, 07:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-973

  3. Oli Bartsch uploaded patch set 2 01/08/21, 21:03

  4. Benni Mack marked it ready for review 01/08/21, 21:08

  5. TYPO3com voted on patch set 2 V -1 01/08/21, 21:16 Completed build in 12m 24s on Fri, 8 Jan, 09:16 PM Test Summary: 1 of 75789 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-974

  6. TYPO3com voted on patch set 2 V +1 01/08/21, 21:35 Completed build in 44m 16s on Fri, 8 Jan, 09:35 PM Test Summary: 75304 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-974

  7. Benni Mack voted on patch set 2 V +2 CR +2 01/08/21, 21:36

  8. Benni Mack merged patch set 3 01/08/21, 21:36

  9. TYPO3com commented on patch set 2 01/08/21, 21:38 Completed build in 14m 27s on Fri, 8 Jan, 09:38 PM Test Summary: 75304 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-975