Review main Merged

67392[BUGFIX] Add workspace restriction to RecordsXmlSitemapDataProvider

Richard Haeser CR +2 V +2 Normal +94 −2 updated 01/12/21, 11:04

Commit message

By adding the workspace restriction to the RecordsXmlSitemapDataProvider,
only records in the live workspace are shown in the XML sitemap.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1318

  1. Richard Haeser uploaded patch set 1 01/10/21, 02:18

  2. TYPO3com voted on patch set 1 V +1 01/10/21, 02:29 Completed build in 10m 02s on Sun, 10 Jan, 02:29 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8791

  3. Richard Haeser uploaded patch set 2 01/10/21, 02:30

  4. TYPO3com voted on patch set 2 V -1 01/10/21, 02:40 Completed build in 09m 24s on Sun, 10 Jan, 02:40 AM Test Summary: 1 of 32813 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8792

  5. Richard Haeser uploaded patch set 3 01/10/21, 02:43

  6. TYPO3com voted on patch set 3 V +1 01/10/21, 02:55 Completed build in 11m 28s on Sun, 10 Jan, 02:55 AM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8793

  7. Guido Schmechel voted on patch set 3 V +1 CR +1 01/10/21, 11:55

  8. Christian Kuhn voted on patch set 3 CR +1 01/10/21, 11:57

  9. Benni Mack commented on patch set 3 CR -1 01/11/21, 07:15

    RecordsXmlSitemapDataProvider.php:105

    This change never allows to run the XmlSitemap in a workspace, as it always defaults to workspace "0". we would need to define the Workspace Restriction and add the first constructor argument from e.g. the Context API.
  10. Richard Haeser commented on patch set 3 01/11/21, 07:19

    RecordsXmlSitemapDataProvider.php:105 Reply

    I thought about that but couldn’t really find the use case for checking the xml sitemap in a workspace. only reason would be to check if new pages in workspace would show up in the sitemap. but I will check if it does not have negative side effects when we make this available in a workspace as well.
  11. Richard Haeser uploaded patch set 4 01/11/21, 14:41

  12. TYPO3com voted on patch set 4 V -1 01/11/21, 14:52 Completed build in 11m 03s on Mon, 11 Jan, 02:52 PM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8808

  13. TYPO3com voted on patch set 4 V +1 01/11/21, 15:19 Completed build in 49m 16s on Mon, 11 Jan, 03:19 PM Test Summary: 32573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8808

  14. Benni Mack voted on patch set 4 CR +1 01/11/21, 15:23

  15. Christian Kuhn voted on patch set 4 V +1 CR +1 01/12/21, 10:54

  16. Richard Haeser commented on patch set 4 01/12/21, 11:03

    RecordsXmlSitemapDataProvider.php:105 Reply

    Done
  17. Benni Mack voted on patch set 4 V +2 CR +2 01/12/21, 11:04

  18. Benni Mack merged patch set 5 01/12/21, 11:04