67392[BUGFIX] Add workspace restriction to RecordsXmlSitemapDataProvider
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/seo/Classes/XmlSitemap/RecordsXmlSitemapDataProvider.php3+14 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/records.typoscript+15 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/sys_category.xml+15 −0
- typo3/sysext/seo/Tests/Functional/Fixtures/sys_news.xmlnew+25 −0
- typo3/sysext/seo/Tests/Functional/XmlSitemap/XmlSitemapRecordsTest.php+25 −2
Review log 1318
-
Richard Haeser uploaded patch set 1 01/10/21, 02:18
-
TYPO3com voted on patch set 1 V +1 01/10/21, 02:29 Completed build in 10m 02s on Sun, 10 Jan, 02:29 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8791
-
Richard Haeser uploaded patch set 2 01/10/21, 02:30
-
TYPO3com voted on patch set 2 V -1 01/10/21, 02:40 Completed build in 09m 24s on Sun, 10 Jan, 02:40 AM Test Summary: 1 of 32813 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8792
-
Richard Haeser uploaded patch set 3 01/10/21, 02:43
-
TYPO3com voted on patch set 3 V +1 01/10/21, 02:55 Completed build in 11m 28s on Sun, 10 Jan, 02:55 AM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8793
-
Guido Schmechel voted on patch set 3 V +1 CR +1 01/10/21, 11:55
-
Christian Kuhn voted on patch set 3 CR +1 01/10/21, 11:57
-
Benni Mack commented on patch set 3 CR -1 01/11/21, 07:15
-
Richard Haeser commented on patch set 3 01/11/21, 07:19
RecordsXmlSitemapDataProvider.php:105ReplyI thought about that but couldn’t really find the use case for checking the xml sitemap in a workspace. only reason would be to check if new pages in workspace would show up in the sitemap. but I will check if it does not have negative side effects when we make this available in a workspace as well. -
Richard Haeser uploaded patch set 4 01/11/21, 14:41
-
TYPO3com voted on patch set 4 V -1 01/11/21, 14:52 Completed build in 11m 03s on Mon, 11 Jan, 02:52 PM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8808
-
TYPO3com voted on patch set 4 V +1 01/11/21, 15:19 Completed build in 49m 16s on Mon, 11 Jan, 03:19 PM Test Summary: 32573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8808
-
Benni Mack voted on patch set 4 CR +1 01/11/21, 15:23
-
Christian Kuhn voted on patch set 4 V +1 CR +1 01/12/21, 10:54
-
Richard Haeser commented on patch set 4 01/12/21, 11:03
RecordsXmlSitemapDataProvider.php:105ReplyDone -
Benni Mack voted on patch set 4 V +2 CR +2 01/12/21, 11:04
-
Benni Mack merged patch set 5 01/12/21, 11:04
RecordsXmlSitemapDataProvider.php:105