Review main Merged

67393[BUGFIX] Restore styling of Form Framework Wizard

Jonas Eberle CR +2 V +2 Easy +5 −1 updated 02/11/21, 18:27

Commit message

This fixes step indicators and button margins in the modal footer.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Martin Kutschker +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jonas Eberle +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Jonas Eberle uploaded patch set 1 01/10/21, 14:07

  2. Jonas Eberle commented on patch set 1 01/10/21, 14:11

    I wasn't able to fix the misbehaving multistep wizard and would be thankful if somebody could take over.
  3. Jonas Eberle marked it work in progress 01/10/21, 14:12

  4. TYPO3com voted on patch set 1 V +1 01/10/21, 14:16 Completed build in 09m 10s on Sun, 10 Jan, 02:16 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8796

  5. Benni Mack commented on patch set 1 01/17/21, 11:30

    This change is ready for review.

    _modal.scss:323

    we should use "rem" for the future.
  6. Martin Kutschker commented on patch set 1 01/31/21, 16:48

    _modal.scss:323 Reply Unresolved

    As this styling is local I suggest em, so the spacing changes with the font size of the button.
  7. Richard Haeser commented on patch set 1 CR -1 02/11/21, 14:23

    On it

    _modal.scss:326

    This one is already fixed in another patch
  8. Richard Haeser uploaded patch set 2 02/11/21, 14:58

  9. Richard Haeser commented on patch set 2 V +1 CR +1 02/11/21, 14:58

    _modal.scss:326 Reply

    Done
  10. TYPO3com voted on patch set 2 V +1 02/11/21, 15:07 Completed build in 08m 40s on Thu, 11 Feb, 03:07 PM Test Summary: 32605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9470

  11. Benjamin Franzke updated the commit message in patch set 3 02/11/21, 15:09

  12. core-ci voted on patch set 2 V +1 02/11/21, 15:13 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/648

  13. TYPO3com voted on patch set 3 V +1 02/11/21, 15:17 Completed build in 08m 17s on Thu, 11 Feb, 03:17 PM Test Summary: 32605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9471

  14. Richard Haeser voted on patch set 3 V +1 CR +1 02/11/21, 15:19

  15. core-ci voted on patch set 3 V +1 02/11/21, 15:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/649

  16. Jonas Eberle voted on patch set 3 V +1 02/11/21, 15:28

  17. Martin Kutschker voted on patch set 3 CR +1 02/11/21, 17:13

  18. Richard Haeser voted on patch set 3 V +2 CR +2 02/11/21, 18:27

  19. Richard Haeser merged patch set 4 02/11/21, 18:27