Review main Merged

67394[BUGFIX] Multiple languages in the update command

Guido Schmechel CR +2 V +2 Easy +5 −0 updated 05/04/21, 09:58

Commit message

If a TYPO3 integrator creates the scheduler command
language:update and defines multiple languages,
e.g. de fr pt, then this is now interpreted.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1011

  1. Guido Schmechel uploaded patch set 1 01/10/21, 16:01

  2. TYPO3com voted on patch set 1 V +1 01/10/21, 16:12 Completed build in 10m 48s on Sun, 10 Jan, 04:12 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8797

  3. Richard Haeser voted on patch set 1 CR +1 01/11/21, 19:57

  4. Benni Mack commented on patch set 1 01/14/21, 08:08

    seems like this is an issue with the actual Scheduler "ExecuteSchedulableCommandTask" that this option is actually not transferred as array (like the direct CLI command is doing) but as string. Although this change works, I think we could fix this in the scheduler task so that all commands benefit from it and we don't need a workaround in all places. What do you think?
  5. Guido Schmechel commented on patch set 1 CR -1 01/14/21, 22:53

    Reply

    What is needed is more of a streamline. If the type is array, the scheduler task expects a comma-separated list. see https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandAdditionalFieldProvider.php#L214 The symfony task would of course like to have a space-separated list for an array. From my point of view, we would have to adjust only the Command. Sounds to me more like a job to straighten out the LanguageCommand, which would be breaking. Or we make it completely simple and ultimately only adapt the documentation ;-)
  6. Benni Mack commented on patch set 1 CR +1 04/27/21, 20:49

    Reply Unresolved

    Let's go with the current approach, then!
  7. Guido Schmechel wrote 04/28/21, 08:13

    Removed Code-Review-1 by Guido Schmechel <guido.schmechel@brandung.de>
  8. Guido Schmechel commented on patch set 1 05/03/21, 21:43

    If you don't see the option to add this task as scheduler, please check https://review.typo3.org/c/Packages/TYPO3.CMS/+/68981 before
  9. Andreas Kienast voted on patch set 1 V +1 CR +1 05/04/21, 05:58

  10. Richard Haeser voted on patch set 1 V +2 CR +2 05/04/21, 09:58

  11. Richard Haeser merged patch set 2 05/04/21, 09:58