Review main Merged

67396[TASK] No reference index for workspace delete placeholders

Christian Kuhn CR +2 V +2 Easy +9 −35 updated 01/13/21, 17:56

Commit message

The reference index can be seen as a 'cache' for
consuming application parts other than the
DataHandler, which does not rely on it's state but
keeps it updated.

From this point of view, workspace delete placeholders
(t3ver_state=2 records) should not have reference
index entries: The delete placeholder is just a
marker that a specific live record is slated for
deletion upon publish. It does not carry relation
information on it's own.

The patch changes reference index code to not
consider relations for workspace delete placeholder
records.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 19

Review log 1118

  1. Christian Kuhn uploaded patch set 1 01/10/21, 17:29

  2. TYPO3com voted on patch set 1 V -1 01/10/21, 17:39 Completed build in 09m 37s on Sun, 10 Jan, 05:39 PM Test Summary: 54 of 32810 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8799

  3. Christian Kuhn uploaded patch set 2 01/10/21, 17:57

  4. TYPO3com voted on patch set 2 V -1 01/10/21, 18:07 Completed build in 09m 57s on Sun, 10 Jan, 06:07 PM Test Summary: 15 of 32810 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8800

  5. Christian Kuhn uploaded patch set 3 01/10/21, 18:09

  6. TYPO3com voted on patch set 3 V -1 01/10/21, 18:19 Completed build in 09m 30s on Sun, 10 Jan, 06:19 PM Test Summary: 12 of 32810 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8801

  7. Christian Kuhn uploaded patch set 4 01/11/21, 11:22

  8. TYPO3com voted on patch set 4 V -1 01/11/21, 11:32 Completed build in 09m 30s on Mon, 11 Jan, 11:31 AM Test Summary: 6 of 32810 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8805

  9. Christian Kuhn uploaded patch set 5 01/12/21, 11:34

  10. Christian Kuhn uploaded patch set 6 01/12/21, 11:44

  11. TYPO3com voted on patch set 5 V -1 01/12/21, 11:45 Completed build in 10m 36s on Tue, 12 Jan, 11:45 AM Test Summary: 3 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8822

  12. Christian Kuhn uploaded patch set 7 01/12/21, 11:56

  13. TYPO3com voted on patch set 6 V -1 01/12/21, 11:56 Completed build in 11m 50s on Tue, 12 Jan, 11:56 AM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8824

  14. TYPO3com voted on patch set 7 V +1 01/12/21, 12:05 Completed build in 09m 39s on Tue, 12 Jan, 12:05 PM Test Summary: 32573 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8825

  15. Anja Leichsenring voted on patch set 7 V +1 CR +1 01/12/21, 12:07

  16. Richard Haeser voted on patch set 7 V +2 CR +2 01/12/21, 12:25

  17. Richard Haeser merged patch set 8 01/12/21, 12:25

  18. Christian Kuhn wrote 01/13/21, 17:56

    Created a revert of this change as I19b36d011b3cae2c3c17763ace8e5ff22f8dfe9b