Review main Merged

67400[BUGFIX] Do not turn workspace delete records into move records

Christian Kuhn CR +2 V +2 Normal +32 −26 updated 01/12/21, 11:23

Commit message

Scenario: A live page has a page localization. In workspaces,
the page localization is deleted, creating a delete placeholder.
After that, the page is moved to a different parent page in
workspaces. The delete placeholder of the localization is then
turned into a move placeholder.
This is wrong since the delete information is lost.
The patch suppresses the change of delete placeholders to move
placeholders when moving records.
This issue is much harder to solve in v10 since v10 has to deal
with two move overlay records and v11 with one. The patch is
thus slated for v11 only.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 710

  1. Christian Kuhn uploaded patch set 1 01/11/21, 15:58

  2. TYPO3com voted on patch set 1 V -1 01/11/21, 16:08 Completed build in 10m 01s on Mon, 11 Jan, 04:08 PM Test Summary: 12 of 32808 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8809

  3. Christian Kuhn uploaded patch set 2 01/11/21, 17:36

  4. TYPO3com voted on patch set 2 V +1 01/11/21, 17:45 Completed build in 09m 17s on Mon, 11 Jan, 05:45 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8811

  5. Christian Kuhn uploaded patch set 3 01/11/21, 17:47

  6. TYPO3com voted on patch set 3 V +1 01/11/21, 17:57 Completed build in 09m 42s on Mon, 11 Jan, 05:57 PM Test Summary: 32568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8812

  7. Richard Haeser voted on patch set 3 V +1 CR +1 01/12/21, 10:56

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 01/12/21, 11:22

  9. Richard Haeser voted on patch set 3 V +2 CR +2 01/12/21, 11:22

  10. Richard Haeser merged patch set 4 01/12/21, 11:23