Review main Merged

67401[TASK] Reduce RelationHandler state

Oli Bartsch CR +2 V +2 Normal +21 −47 updated 01/12/21, 10:36

Commit message

Some protected properties with single usage are replaced
with local variables to reduce complexity.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1116

  1. Oli Bartsch uploaded patch set 1 01/11/21, 18:04

  2. TYPO3com voted on patch set 1 V -1 01/11/21, 18:14 Completed build in 09m 51s on Mon, 11 Jan, 06:14 PM Test Summary: 32558 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8813

  3. TYPO3com voted on patch set 1 V +1 01/11/21, 19:00 Completed build in 1h 06m 22s on Mon, 11 Jan, 07:00 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8813

  4. Oli Bartsch uploaded patch set 2 01/11/21, 19:17

  5. Oli Bartsch uploaded patch set 3 01/11/21, 19:27

  6. TYPO3com voted on patch set 2 V +1 01/11/21, 19:27 Completed build in 10m 08s on Mon, 11 Jan, 07:27 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8814

  7. TYPO3com voted on patch set 3 V +1 01/11/21, 19:38 Completed build in 10m 30s on Mon, 11 Jan, 07:38 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8815

  8. Richard Haeser commented on patch set 3 01/11/21, 19:54

    RelationHandler.php:397

    Do we need to set this local variable within the foreach loop?
  9. Oli Bartsch uploaded patch set 4 01/11/21, 20:00

  10. Richard Haeser voted on patch set 4 CR +1 01/11/21, 20:01

  11. Oli Bartsch commented on patch set 4 01/11/21, 20:01

    RelationHandler.php:397 Reply

    Done
  12. TYPO3com voted on patch set 4 V +1 01/11/21, 20:10 Completed build in 10m 09s on Mon, 11 Jan, 08:10 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8817

  13. Christian Kuhn commented on patch set 4 V +1 CR +1 01/12/21, 10:23

    thx!
  14. Richard Haeser voted on patch set 4 V +1 01/12/21, 10:35

  15. Richard Haeser voted on patch set 4 V +2 CR +2 01/12/21, 10:36

  16. Richard Haeser merged patch set 5 01/12/21, 10:36