Review main Merged

67402[BUGFIX] Show system news navigation buttons

Martin Kutschker CR +2 V +2 Easy +14 −12 updated 01/12/21, 14:18

Commit message

Due to CSS changes in Boostrap 5 the navigation buttons
on the login screen were invisible.

This patch makes them visible again.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 69

  1. Martin Kutschker uploaded patch set 1 01/11/21, 20:16

  2. Martin Kutschker uploaded patch set 2 01/11/21, 20:24

  3. TYPO3com voted on patch set 1 V +1 01/11/21, 20:27 Completed build in 10m 33s on Mon, 11 Jan, 08:27 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8818

  4. TYPO3com voted on patch set 2 V -1 01/11/21, 20:35 Completed build in 10m 28s on Mon, 11 Jan, 08:35 PM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8819

  5. Martin Kutschker commented on patch set 2 01/12/21, 08:11

    Just a flakey test: LoginCest » Install tool login 0s unknown error: DevToolsActivePort file doesn't exist (Driver info: chromedriver=2.40.565383 (76257d1ab79276b2d53ee976b2c3e3b9f335cde7),platform=Linux 4.15.0-130-generic x86_64) (WARNING: The server did not provide any stacktrace information) Command duration or timeout: 60.09 seconds Build info: version: '3.12.0', revision: '7c6e0b3', time: '2018-05-08T15:15:08.936Z' System info: host: '954a05f24696', ip: '192.168.12.5', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-130-generic', java.version: '1.8.0_171' Driver info: driver.version: unknown
  6. TYPO3com voted on patch set 2 V +1 01/12/21, 12:53 Completed build in 08m 57s on Tue, 12 Jan, 12:53 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8828

  7. Richard Haeser voted on patch set 2 V +1 CR +1 01/12/21, 12:59

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 01/12/21, 14:18

  9. Benjamin Franzke merged patch set 3 01/12/21, 14:18