Review main Merged

67413Revert "[TASK] No reference index for workspace delete placeholders"

Christian Kuhn CR +2 V +2 Easy +35 −9 updated 01/22/21, 22:45

Commit message

This reverts commit 84948b2c4d8740f1dcec352eb357337c23cc28f4.

The strategy to not have reference index entries for
workspace delete placeholders does not work out (for now):

* Workspace ElementEntity class relies on it and is
  used by DataHandler during workspace operations.

* Patch was incomplete: While rows 'from' affected
  records were dropped in refindex, rows 'to' affected
  records were left.

We may later pick this up again, but need more refactoring.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 19

Review log 812

  1. Christian Kuhn uploaded patch set 1 01/13/21, 17:56

  2. Christian Kuhn voted on patch set 1 CR -1 01/13/21, 17:57

  3. TYPO3com voted on patch set 1 V +1 01/13/21, 18:06 Completed build in 09m 44s on Wed, 13 Jan, 06:06 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8853

  4. Christian Kuhn uploaded patch set 2 01/13/21, 18:44

  5. Richard Haeser voted on patch set 2 V +1 CR +1 01/13/21, 23:39

  6. TYPO3com commented on patch set 1 01/14/21, 14:32 Completed build in 22m 58s on Thu, 14 Jan, 02:32 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8853

  7. Christian Kuhn rebased onto patch set 3 01/22/21, 20:38

  8. Christian Kuhn updated the commit message in patch set 4 01/22/21, 20:39

  9. TYPO3com voted on patch set 3 V +1 01/22/21, 20:48 Completed build in 09m 19s on Fri, 22 Jan, 08:48 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9005

  10. TYPO3com voted on patch set 4 V +1 01/22/21, 20:50 Completed build in 10m 16s on Fri, 22 Jan, 08:50 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9006

  11. Benni Mack voted on patch set 4 V +2 CR +2 01/22/21, 22:45

  12. Benni Mack merged patch set 5 01/22/21, 22:45