Review main Merged

6742[FEATURE] Add possibility to define http-equiv in meta tags

Oliver Hader CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Add possibility to define http-equiv in meta tags, currently
this is only done if using the property "refresh".

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Markus Klein +1

Issues 2

Files 1

Review log 21

  1. Markus Klein commented on patch set 1 12/15/11, 20:51

    Isn't this a feature? And I guess this dependency is also superfluous.
  2. Dmitry Dulepov commented on patch set 2 12/15/11, 20:51

    Looks good to me, approved
  3. Markus Klein uploaded patch set 2 12/15/11, 20:51

  4. Dmitry Dulepov commented on patch set 3 12/15/11, 20:51

    Looks good to me, approved
  5. Markus Klein uploaded patch set 3 12/15/11, 20:51

  6. Markus Klein commented on patch set 4 12/15/11, 20:51

    Looks good to me, but someone else must approve
  7. Markus Klein commented on patch set 4 1 comment 12/15/11, 20:51

    Fails; I would prefer that you didn't submit this
  8. Markus Klein uploaded patch set 5 12/15/11, 20:51

  9. Markus Klein commented on patch set 5 12/15/11, 20:51

    Verified; Looks good to me, but someone else must approve
  10. Oliver Hader uploaded patch set 4 12/15/11, 20:51

  11. Oliver Hader commented on patch set 4 12/15/11, 20:51

    Verified; Looks good to me, approved Rebasing to master V:1, R:2 V:0, R:2 from Dmitry Dulepov <dmitry@typo3.org> V:1, R:2 from Steffen Ritter <info@rs-websystems.de>
  12. Georg Ringer commented on patch set 2 12/15/11, 20:51

    (1 inline comment)
  13. Steffen Gebert commented on patch set 1 12/15/11, 20:51

    (1 inline comment)
  14. Steffen Ritter commented on patch set 3 12/15/11, 20:51

    Verified; Looks good to me, approved
  15. Jigal van Hemert commented on patch set 1 12/15/11, 20:51

    I would prefer that you didn't submit this What is that dependency doing here? Maybe it needs to be rebased/cherry-picked to current master? Please fix commit message while doing that.
    It's a feature, not a bugfix
    Which releases?
  16. Jigal van Hemert commented on patch set 5 V 0 12/15/11, 20:51

    by team member; Looks good to me, approved
  17. Mr. Jenkins commented on patch set 2 12/15/11, 20:51

  18. Mr. Jenkins commented on patch set 3 12/15/11, 20:51

  19. Mr. Jenkins commented on patch set 4 12/15/11, 20:51

  20. Mr. Jenkins commented on patch set 5 12/15/11, 20:51

  21. Jigal van Hemert merged patch set 5 12/15/11, 20:51