Review main Merged

6743[TASK] Usability: Replace "Sitemap" with "Special Menus"

Mario Rimann CR +2 V +2 Easy +9 −6 updated 06/03/13, 20:49

Commit message

Changes the labels to be a bit more general since this CType can
be used for more than just sitemaps. Also changes the default
menu type.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Georg Ringer +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1

Issues 1

Files 3

Review log 25

  1. Stefan Neufeind commented on patch set 1 06/27/12, 16:38

    Looks good to me, but someone else must approve
  2. Mario Rimann commented on patch set 2 06/27/12, 16:38

    @Felix: I'm fine if you could push a new version of the patch. And I think Xavier is right: This will be the least troublesome to just add this for 4.7 only and for this add a new XLIFF label. IMHO they don't get deprecated at all (since they're still used in older versions)
  3. Stefan Neufeind commented on patch set 2 06/27/12, 16:38

    Xavier's concerns are valid. But we only need "some" resolution to this (for BC). Somebody please put a final word on how to solve this and we're almost through :-)
  4. Stefan Neufeind commented on patch set 2 06/27/12, 16:38

    Looks good to me, but someone else must approve
  5. Oliver Hader uploaded patch set 2 06/27/12, 16:38

  6. Oliver Hader commented on patch set 2 06/27/12, 16:38

    Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de>
  7. Xavier Perseguers commented on patch set 2 06/27/12, 16:38

    I would prefer that you didn't submit this Please see my comment

    locallang_db_new_content_el.xlf:84

    This will for sure break older releases of TYPO3 as the labels are shared among all versions. Please introduce a new label or make the change for all releases of TYPO3 (would be best from my POV but may be problematic with client's documentation with screenshots)
  8. Philipp Gampe commented on patch set 2 06/27/12, 16:38

    Verified; Looks good to me, but someone else must approve Works fine
  9. Felix Kopp commented on patch set 2 06/27/12, 16:38

    (1 inline comment) I would supply the patch if (re-) adding the former labels is okay.

    locallang_db_new_content_el.xlf:84

    Before: special_sitemap_title After: special_menus_title Is the easiest way to add the former labels (special_sitemap_title & special_sitemap_description) to the new xliff-file? How to deprecate a xliff-label?
  10. Oliver Klee commented on patch set 3 06/27/12, 16:38

    (1 inline comment)
  11. Felix Kopp uploaded patch set 3 06/27/12, 16:38

  12. Felix Kopp commented on patch set 3 06/27/12, 16:38

    Shall this be patchset be merged for 6.0 or abandoned? There seems to be not progress. Is there only the release version missing in commit message?
  13. Stefan Neufeind commented on patch set 4 06/27/12, 16:38

    Looks good to me, but someone else must approve
  14. Christian Kuhn commented on patch set 4 06/27/12, 16:38

    Nice. This one nagged me for a LONG time. Thanks. Merged.
  15. Georg Ringer commented on patch set 4 06/27/12, 16:38

    Verified; Looks good to me, but someone else must approve
  16. Felix Kopp uploaded patch set 4 06/27/12, 16:38

  17. Mr. Jenkins commented on patch set 1 06/27/12, 16:38

    No score; No score Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2437/ : SUCCESS
  18. Mr. Jenkins commented on patch set 1 06/27/12, 16:38

  19. Mr. Jenkins commented on patch set 1 06/27/12, 16:38

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2435/ : FAILURE
  20. Mr. Jenkins commented on patch set 2 06/27/12, 16:38

  21. Mr. Jenkins commented on patch set 3 06/27/12, 16:38

  22. Mr. Jenkins commented on patch set 4 06/27/12, 16:38

  23. Wouter Wolters commented on patch set 2 06/27/12, 16:38

    Verified; Looks good to me, but someone else must approve
  24. Christian Kuhn commented on patch set 4 V 0 06/27/12, 16:38

    by team member; Looks good to me, approved Nice. This one nagged me for a LONG time. Thanks. Merged.
  25. Christian Kuhn merged patch set 4 06/27/12, 16:38