6743[TASK] Usability: Replace "Sitemap" with "Special Menus"
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Stefan Neufeind +1
- Georg Ringer +1
-
Verified V +2
- Christian Kuhn +2
- Georg Ringer +1
Issues 1
Files 3
Review log 25
-
Stefan Neufeind commented on patch set 1 06/27/12, 16:38
Looks good to me, but someone else must approve -
Mario Rimann commented on patch set 2 06/27/12, 16:38
@Felix: I'm fine if you could push a new version of the patch. And I think Xavier is right: This will be the least troublesome to just add this for 4.7 only and for this add a new XLIFF label. IMHO they don't get deprecated at all (since they're still used in older versions) -
Stefan Neufeind commented on patch set 2 06/27/12, 16:38
Xavier's concerns are valid. But we only need "some" resolution to this (for BC). Somebody please put a final word on how to solve this and we're almost through :-) -
Stefan Neufeind commented on patch set 2 06/27/12, 16:38
Looks good to me, but someone else must approve -
Oliver Hader uploaded patch set 2 06/27/12, 16:38
-
Oliver Hader commented on patch set 2 06/27/12, 16:38
Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> -
Xavier Perseguers commented on patch set 2 06/27/12, 16:38
I would prefer that you didn't submit this Please see my commentlocallang_db_new_content_el.xlf:84This will for sure break older releases of TYPO3 as the labels are shared among all versions. Please introduce a new label or make the change for all releases of TYPO3 (would be best from my POV but may be problematic with client's documentation with screenshots) -
Philipp Gampe commented on patch set 2 06/27/12, 16:38
Verified; Looks good to me, but someone else must approve Works fine -
Felix Kopp commented on patch set 2 06/27/12, 16:38
(1 inline comment) I would supply the patch if (re-) adding the former labels is okay.locallang_db_new_content_el.xlf:84Before: special_sitemap_title After: special_menus_title Is the easiest way to add the former labels (special_sitemap_title & special_sitemap_description) to the new xliff-file? How to deprecate a xliff-label? -
Oliver Klee commented on patch set 3 06/27/12, 16:38
(1 inline comment) -
Felix Kopp uploaded patch set 3 06/27/12, 16:38
-
Felix Kopp commented on patch set 3 06/27/12, 16:38
Shall this be patchset be merged for 6.0 or abandoned? There seems to be not progress. Is there only the release version missing in commit message? -
Stefan Neufeind commented on patch set 4 06/27/12, 16:38
Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 4 06/27/12, 16:38
Nice. This one nagged me for a LONG time. Thanks. Merged. -
Georg Ringer commented on patch set 4 06/27/12, 16:38
Verified; Looks good to me, but someone else must approve -
Felix Kopp uploaded patch set 4 06/27/12, 16:38
-
Mr. Jenkins commented on patch set 1 06/27/12, 16:38
No score; No score Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2437/ : SUCCESS -
Mr. Jenkins commented on patch set 1 06/27/12, 16:38
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2436/ : FAILURE -
Mr. Jenkins commented on patch set 1 06/27/12, 16:38
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/2435/ : FAILURE -
Mr. Jenkins commented on patch set 2 06/27/12, 16:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2673/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/27/12, 16:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3724/ : SUCCESS -
Mr. Jenkins commented on patch set 4 06/27/12, 16:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/4593/ : SUCCESS -
Wouter Wolters commented on patch set 2 06/27/12, 16:38
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 4 V 0 06/27/12, 16:38
by team member; Looks good to me, approved Nice. This one nagged me for a LONG time. Thanks. Merged. -
Christian Kuhn merged patch set 4 06/27/12, 16:38