Review main Merged

67433[FEATURE] FAL: Add getFile() methods in Folder objects

Benni Mack CR +2 V +2 Easy +48 −0 updated 04/27/21, 19:18

Commit message

This change adds a getFile() implementation within the FAL Folder object,
which is very convenient compared to $folder->getStorage()->getFileInFolder("filename.ext", $folder)

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack uploaded patch set 1 01/12/21, 11:26

  2. TYPO3com voted on patch set 1 V +1 01/12/21, 11:37 Completed build in 09m 55s on Tue, 12 Jan, 11:37 AM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8821

  3. Benni Mack uploaded patch set 2 04/27/21, 17:47

  4. core-ci voted on patch set 2 V +1 04/27/21, 17:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10755

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 04/27/21, 18:38

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 04/27/21, 19:18

  7. Daniel Goerz merged patch set 3 04/27/21, 19:18