Review main Merged

67438[BUGFIX] Fix RenameFile and FileDelete in EXT:filelist

Oli Bartsch CR +2 V +2 Easy +16 −8 updated 01/13/21, 10:29

Commit message

The RenameFile JavaScript handles renaming of files
and folders. If renaming a folder, some input fields are
not available in the form and must therefore be checked
for existence, before accessing their value.

Furthermore does the file delete modal now display the
modal content again. The corresponding data attribute
was renamed in the bootstrap v5 migration.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 46

  1. Oli Bartsch uploaded patch set 1 01/12/21, 18:16

  2. TYPO3com voted on patch set 1 V -1 01/12/21, 18:26 Completed build in 09m 43s on Tue, 12 Jan, 06:26 PM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8835

  3. TYPO3com voted on patch set 1 V +1 01/12/21, 18:30 Completed build in 23m 31s on Tue, 12 Jan, 06:30 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8835

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 01/13/21, 10:21

  5. Benni Mack voted on patch set 1 V +2 CR +2 01/13/21, 10:29

  6. Benni Mack merged patch set 2 01/13/21, 10:29