Review main Merged

67440[BUGFIX] Delay error handler registration

Benjamin Franzke CR +2 V +2 Easy +11 −1 updated 05/11/21, 18:16

Commit message

The ErrorHandler is not be fully configured (missing logger) by the
time the object is constructed, but the error handler is registered
at that point. As errors may happen during construction of dependencies
(again the logger) of the ErrorHandler, the error handler registration
needs to be delayed in order to avoid usage of the error handler while
dependencies are still being created. This may happen in case an
exception occurs during creation of the ErrorHandler's logger instances.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2029

Show 24 earlier messages
  1. Benjamin Franzke uploaded patch set 1 01/12/21, 22:07

  2. TYPO3com voted on patch set 1 V -1 01/12/21, 22:07 Completed build in 22s on Tue, 12 Jan, 10:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8837

  3. Benjamin Franzke uploaded patch set 2 01/12/21, 22:09

  4. TYPO3com voted on patch set 2 V +1 01/12/21, 22:20 Completed build in 11m 14s on Tue, 12 Jan, 10:20 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8838

  1. Benjamin Franzke uploaded patch set 3 01/12/21, 23:20

  2. Benjamin Franzke commented on patch set 3 01/12/21, 23:27

    @helhum: Adding you to CC in case you see potential of breaking TYPO3 Console versions. I looked i As far as I saw typo3-console has custom setup for error handlers, but also only registeres an own ErrorHandler, so it shouldn't be affected. Also the distrubtion stuff like https://github.com/helhum/TYPO3-Distribution/tree/master/packages/typo3-error-handling doesn't fiddle with the error handler – just with the exception handler. So we should be OK here(?)
  3. TYPO3com voted on patch set 3 V +1 01/12/21, 23:31 Completed build in 10m 22s on Tue, 12 Jan, 11:31 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8842

  4. Franz Holzinger commented on patch set 3 V +1 01/22/21, 17:28

    I have tested the patch under TYPO3 9.5.24. This really helps to find a PHP error which happens at the very beginning of the TYPO3 run. The new method registerErrorHandler needs a comment.
  5. Benjamin Franzke wrote 03/10/21, 21:25

    Topic set to bootstrap
  6. Benjamin Franzke wrote 03/10/21, 21:26

    Topic bootstrap removed
  7. Benni Mack voted on patch set 3 V +1 CR +1 03/22/21, 18:43

  8. Christian Kuhn commented on patch set 3 03/26/21, 10:55

    rebasing to current head.
  9. Christian Kuhn rebased onto patch set 4 03/26/21, 10:55

  10. core-ci voted on patch set 4 V +1 03/26/21, 11:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1850

  11. Christian Kuhn commented on patch set 4 03/26/21, 14:36

    Unresolved

    minor typo 'dependencies'
  12. Susi Moog voted on patch set 4 CR +1 04/01/21, 06:10

  13. Anja Leichsenring updated the commit message in patch set 5 04/06/21, 15:40

  14. TYPO3com voted on patch set 5 V +1 04/06/21, 15:46 Completed build in 06m 08s on Tue, 6 Apr, 03:46 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10498

  15. core-ci voted on patch set 5 V +1 04/06/21, 15:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2047

  16. Josef Glatz updated the commit message in patch set 6 04/06/21, 16:00

  17. TYPO3com voted on patch set 6 V +1 04/06/21, 16:08 Completed build in 07m 38s on Tue, 6 Apr, 04:08 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10501

  18. core-ci voted on patch set 6 V +1 04/06/21, 16:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2050

  19. Benni Mack voted on patch set 6 CR +1 04/23/21, 20:02

  20. Benni Mack voted on patch set 6 V +1 05/04/21, 12:39

  21. Anja Leichsenring rebased onto patch set 7 05/11/21, 17:48

  22. core-ci voted on patch set 7 V +1 05/11/21, 18:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11384

  23. Benni Mack voted on patch set 7 V +1 CR +1 05/11/21, 18:15

  24. Anja Leichsenring voted on patch set 7 V +2 CR +2 05/11/21, 18:16

  25. Anja Leichsenring merged patch set 8 05/11/21, 18:16