Review main Merged

67441[FEATURE] Synchronize folder relations after rename

Oli Bartsch CR +2 V +2 Hard +379 −6 updated 04/09/21, 20:11

Commit message

To prevent broken records which reference a renamed
folder, the AfterFolderRenamedEvent is now used to
synchronize the corresponding relations as soon as
such action took place.

Furthermore does the AfterFolderRenamedEvent now
contain the source folder, which is necessary to
find those relations.

A flash message informs the user about the
synchronization when the action was performed
in the backend, e.g. in the file module.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 11

Review log 1320

  1. Oli Bartsch uploaded patch set 1 01/12/21, 23:05

  2. TYPO3com voted on patch set 1 V -1 01/12/21, 23:05 Completed build in 25s on Tue, 12 Jan, 11:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8840

  3. Oli Bartsch uploaded patch set 2 01/12/21, 23:07

  4. TYPO3com voted on patch set 2 V +1 01/12/21, 23:18 Completed build in 10m 29s on Tue, 12 Jan, 11:18 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8841

  5. Oli Bartsch uploaded patch set 3 01/13/21, 13:07

  6. TYPO3com voted on patch set 3 V +1 01/13/21, 13:19 Completed build in 11m 30s on Wed, 13 Jan, 01:19 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8848

  7. Oli Bartsch uploaded patch set 4 01/13/21, 15:20

  8. TYPO3com voted on patch set 4 V -1 01/13/21, 15:31 Completed build in 10m 27s on Wed, 13 Jan, 03:31 PM Test Summary: 2 of 32822 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8850

  9. Oli Bartsch uploaded patch set 5 01/13/21, 17:17

  10. TYPO3com voted on patch set 5 V +1 01/13/21, 17:27 Completed build in 10m 28s on Wed, 13 Jan, 05:27 PM Test Summary: 32581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8851

  11. Oli Bartsch uploaded patch set 6 01/14/21, 15:48

  12. TYPO3com voted on patch set 6 V -1 01/14/21, 15:49 Completed build in 23s on Thu, 14 Jan, 03:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8856

  13. Oli Bartsch uploaded patch set 7 01/14/21, 15:50

  14. TYPO3com voted on patch set 7 V +1 01/14/21, 16:00 Completed build in 09m 23s on Thu, 14 Jan, 04:00 PM Test Summary: 32581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8857

  15. Benni Mack voted on patch set 7 V +1 CR +1 01/19/21, 09:29

  16. Richard Haeser commented on patch set 7 V +1 01/19/21, 09:52

    I'm in doubt if the change of the Event is a breaking change. It depends if we see PSR-14 events of core as internal or not. See https://typo3.slack.com/archives/C03AM9R17/p1611049639107200. Furthermore it works fine and code is looking fine as well.
  17. Richard Haeser commented on patch set 7 V +2 CR +2 01/19/21, 10:14

    As discussed on Slack, dispatching this event should be only done by core, so no breaking change. We might want to document such a policy though.
  18. Richard Haeser merged patch set 8 01/19/21, 10:14

  19. Sybille Peters commented on patch set 8 04/08/21, 15:38

    Is there any chance to get this fixed for v10? I assume not since it has been declared as feature. We are sometimes affected by this problem and I am checking if there is any way to resolve it for 10.
  20. Oli Bartsch commented on patch set 8 04/09/21, 20:11

    Reply

    I suggest to create an issue about backporting the changes in the AfterFolderRenamedEvent. Since the event is actually quite useless without any info regarding the source folder, this could be treated as Bug or Task. Afterwards, you can just add the listener by yourself in v10. What do you think?