Review main Merged

67443[BUGFIX] Avoid fatal errors with empty bodytext content

Benni Mack CR +2 V +2 Easy +1 −1 updated 01/13/21, 12:12

Commit message

The page module does not throw a fatal error
anymore if a content type "text" has a bodytext
of value "null" instead of "text".

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Benni Mack uploaded patch set 1 01/13/21, 11:37

  2. Daniel Goerz commented on patch set 1 01/13/21, 11:43

    TextPreviewRenderer.php:32 Unresolved

    please use ?? '' instead
  3. Daniel Goerz commented on patch set 2 01/13/21, 11:45

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 2 01/13/21, 11:45

    TextPreviewRenderer.php:32

    I strongly disagree with this change of MY patch set.
  5. Benni Mack voted on patch set 2 V +1 CR +1 01/13/21, 11:46

  6. Daniel Goerz voted on patch set 2 V +1 CR +1 01/13/21, 11:46

  7. TYPO3com voted on patch set 1 V +1 01/13/21, 11:47 Completed build in 10m 12s on Wed, 13 Jan, 11:47 AM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8846

  8. TYPO3com voted on patch set 2 V +1 01/13/21, 11:54 Completed build in 09m 32s on Wed, 13 Jan, 11:54 AM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8847

  9. Daniel Goerz commented on patch set 2 01/13/21, 12:02

    TextPreviewRenderer.php:32 Reply Unresolved

    Well, this is MY patch set now, muhahaha
  10. Oli Bartsch voted on patch set 2 V +1 CR +1 01/13/21, 12:10

  11. Daniel Goerz voted on patch set 2 V +2 CR +2 01/13/21, 12:12

  12. Daniel Goerz merged patch set 3 01/13/21, 12:12