Review main Merged

67446[BUGFIX] Fix TypeError in TypoScript "split" under DebugExceptionHandler

Dmitry Dulepov CR +2 V +2 Easy +1 −1 updated 02/25/21, 18:30

Commit message

This fix adds a check for the non-existing array member that is passed
to a function that expects an array. In the debug configuration such
missing check causes TypeError exception.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Dmitry Dulepov uploaded patch set 1 01/14/21, 11:49

  2. Oli Bartsch commented on patch set 1 CR -1 01/14/21, 13:11

    ContentObjectRenderer.php:3157 Unresolved

    Please use the null coalescing operator here since it will otherwise still produce a notice (PHP < 8) or a warning (PHP >= 8). See: https://3v4l.org/EpdH5 for an example.
  3. Dmitry Dulepov uploaded patch set 2 01/14/21, 13:23

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 01/14/21, 13:36

  5. Christian Kuhn rebased onto patch set 3 02/25/21, 18:16

  6. core-ci voted on patch set 3 V +1 02/25/21, 18:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1016

  7. TYPO3com voted on patch set 3 V +1 02/25/21, 18:28 Completed build in 12m 10s on Thu, 25 Feb, 06:28 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9732

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 02/25/21, 18:28

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 02/25/21, 18:30

  10. Christian Kuhn merged patch set 4 02/25/21, 18:30