67447[BUGFIX] Respect default values in TcaGroup
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Maik Schneider +1
- Benni Mack +1
-
Verified V +2 Done
- Richard Haeser +2
- Maik Schneider +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Maik Schneider uploaded patch set 1 01/14/21, 13:24
-
Mathias Brodala commented on patch set 1 01/14/21, 13:30
-
Maik Schneider commented on patch set 1 01/14/21, 13:49
TcaGroup.php:78Reply UnresolvedSure, that way the comment is not necessary. However the function parameter needs to be an integer, this isn't guaranteed in this case, plus is_int() is cheaper. But I don't mind the change, looks good. -
TYPO3com voted on patch set 1 V +1 01/16/21, 13:44 Completed build in 09m 27s on Sat, 16 Jan, 01:44 PM Test Summary: 32579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8878
-
Benni Mack commented on patch set 1 CR +1 04/07/21, 19:31
I'm fine with the current approach -
Benni Mack uploaded patch set 2 04/27/21, 11:24
-
core-ci voted on patch set 2 V +1 04/27/21, 11:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10730
-
Benni Mack voted on patch set 2 V +1 CR +1 04/29/21, 17:21
-
Maik Schneider voted on patch set 2 V +1 CR +1 04/29/21, 18:39
-
Richard Haeser voted on patch set 2 V +2 CR +2 04/29/21, 19:22
-
Richard Haeser merged patch set 3 04/29/21, 19:23
TcaGroup.php:78