Review main Merged

67447[BUGFIX] Respect default values in TcaGroup

Maik Schneider CR +2 V +2 Easy +4 −1 updated 04/29/21, 19:23

Commit message

RelationHandler cannot handle vanilla uids, pass 0 instead to correctly parse defVals for MM-relations in TCA type=group

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Maik Schneider +1
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Maik Schneider +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Maik Schneider uploaded patch set 1 01/14/21, 13:24

  2. Mathias Brodala commented on patch set 1 01/14/21, 13:30

    TcaGroup.php:78

    Maybe like this instead: $mmUid = GeneralUtility::isFirstPartOfStr((string)$result['databaseRow'][['uid'], 'NEW')) ? 0 : $result['databaseRow'][['uid']; This would convey the intention a bit clearer.
  3. Maik Schneider commented on patch set 1 01/14/21, 13:49

    TcaGroup.php:78 Reply Unresolved

    Sure, that way the comment is not necessary. However the function parameter needs to be an integer, this isn't guaranteed in this case, plus is_int() is cheaper. But I don't mind the change, looks good.
  4. TYPO3com voted on patch set 1 V +1 01/16/21, 13:44 Completed build in 09m 27s on Sat, 16 Jan, 01:44 PM Test Summary: 32579 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8878

  5. Benni Mack commented on patch set 1 CR +1 04/07/21, 19:31

    I'm fine with the current approach
  6. Benni Mack uploaded patch set 2 04/27/21, 11:24

  7. core-ci voted on patch set 2 V +1 04/27/21, 11:35 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10730

  8. Benni Mack voted on patch set 2 V +1 CR +1 04/29/21, 17:21

  9. Maik Schneider voted on patch set 2 V +1 CR +1 04/29/21, 18:39

  10. Richard Haeser voted on patch set 2 V +2 CR +2 04/29/21, 19:22

  11. Richard Haeser merged patch set 3 04/29/21, 19:23