Review main Merged

67455[BUGFIX] Preserve order of link handlers

Markus Klein CR +2 V +2 Easy +5 −5 updated 01/16/21, 07:14

Commit message

If some link handlers are hidden with "blindLinkOptions" then we still
want to preserve the well-known order of the other tabs.
This is solved by defining more dependencies on the link handlers, so
that the ordering service still has a clue about the order.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benni Mack +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 914

  1. Markus Klein uploaded patch set 1 01/15/21, 21:05

  2. TYPO3com voted on patch set 1 V +1 01/15/21, 21:15 Completed build in 10m 06s on Fri, 15 Jan, 09:15 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8872

  3. Benni Mack uploaded patch set 2 01/15/21, 21:48

  4. Benni Mack voted on patch set 2 V +1 CR +1 01/15/21, 21:49

  5. TYPO3com voted on patch set 2 V -1 01/15/21, 22:00 Completed build in 11m 41s on Fri, 15 Jan, 10:00 PM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8873

  6. Markus Klein commented on patch set 2 CR -1 01/15/21, 22:13

    ext_localconf.php:17

    this is for sure invalid.
  7. Benni Mack commented on patch set 2 01/15/21, 22:31

    ext_localconf.php:17 Reply Unresolved

    BUT IT WORKS :D
  8. Benni Mack uploaded patch set 3 01/15/21, 22:32

  9. TYPO3com voted on patch set 3 V -1 01/15/21, 22:43 Completed build in 10m 33s on Fri, 15 Jan, 10:43 PM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8874

  10. Benni Mack voted on patch set 3 V +1 CR +1 01/15/21, 23:01

  11. TYPO3com commented on patch set 3 01/15/21, 23:04 Completed build in 42m 53s on Fri, 15 Jan, 11:04 PM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8874

  12. TYPO3com voted on patch set 3 V +1 01/15/21, 23:14 Completed build in 1h 24m 30s on Fri, 15 Jan, 11:14 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8874

  13. Richard Haeser voted on patch set 3 V +2 CR +2 01/16/21, 07:14

  14. Richard Haeser merged patch set 4 01/16/21, 07:14